From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, "Daniel Borkmann" <daniel@iogearbox.net>,
"Alexei Starovoitov" <ast@kernel.org>,
"Jakub Kicinski" <jakub.kicinski@netronome.com>,
BjörnTöpel <bjorn.topel@gmail.com>,
brouer@redhat.com
Subject: Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device
Date: Tue, 9 Apr 2019 10:25:59 +0200 [thread overview]
Message-ID: <20190409102559.28cbb37a@carbon> (raw)
In-Reply-To: <155474315681.24432.16316236828243189182.stgit@alrua-x1>
On Mon, 08 Apr 2019 19:05:56 +0200 Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> +void dev_map_put_default_map(struct net *net)
> +{
> + mutex_lock(&dev_map_mtx);
Looks like a white-space error...
> + if (atomic_dec_and_test(&net->xdp.default_map.use_cnt)) {
> + __dev_map_release_default_map(&net->xdp.default_map);
> + }
> + mutex_unlock(&dev_map_mtx);
And here again.
> +}
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-04-09 8:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 17:05 [PATCH net-next v4 0/6] xdp: Use a default map for xdp_redirect helper Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 2/6] net: xdp: remove XDP_QUERY_PROG Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device Toke Høiland-Jørgensen
2019-04-09 8:25 ` Jesper Dangaard Brouer [this message]
2019-04-09 9:23 ` Toke Høiland-Jørgensen
2019-04-10 7:59 ` [xdp] 9cb54e254c: kernel/bpf/devmap.c:#suspicious_rcu_dereference_check() kernel test robot
2019-04-10 7:59 ` kernel test robot
2019-04-10 10:00 ` Toke Høiland-Jørgensen
2019-04-10 10:00 ` Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 3/6] xdp: Refactor devmap code in preparation for subsequent additions Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 5/6] xdp: Add devmap_idx map type for looking up devices by ifindex Toke Høiland-Jørgensen
2019-04-08 17:05 ` [PATCH net-next v4 1/6] net: xdp: refactor XDP attach Toke Høiland-Jørgensen
2019-04-08 20:23 ` Daniel Borkmann
2019-05-09 10:40 ` Björn Töpel
2019-04-09 12:54 ` kbuild test robot
2019-04-08 17:05 ` [PATCH net-next v4 6/6] selftests/bpf: Add test for default devmap allocation Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409102559.28cbb37a@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.