From: Peter Zijlstra <peterz@infradead.org>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Ashok Raj <ashok.raj@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Ricardo Neri <ricardo.neri@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>,
Clemens Ladisch <clemens@ladisch.de>,
Arnd Bergmann <arnd@arndb.de>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Nayna Jain <nayna@linux.ibm.com>
Subject: Re: [RFC PATCH v2 11/14] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector
Date: Tue, 9 Apr 2019 13:03:40 +0200 [thread overview]
Message-ID: <20190409110340.GS4038@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1551283518-18922-12-git-send-email-ricardo.neri-calderon@linux.intel.com>
On Wed, Feb 27, 2019 at 08:05:15AM -0800, Ricardo Neri wrote:
> diff --git a/arch/x86/include/asm/hpet.h b/arch/x86/include/asm/hpet.h
> index 4d559e0c746f..15dc3b576496 100644
> --- a/arch/x86/include/asm/hpet.h
> +++ b/arch/x86/include/asm/hpet.h
> @@ -123,12 +123,24 @@ struct hpet_hld_data {
> u32 num;
> u32 flags;
> u64 ticks_per_second;
> + u32 handling_cpu;
> + struct cpumask cpu_monitored_mask;
> + struct msi_msg msi_msg;
> };
Please don't use struct cpumask unless you absolutely have to.
The above is better written as:
struct hpet_hld_data {
...
unsigned long cpumask[0];
};
and allocated using:
struct hpet_hld_data *hhd = kzalloc(sizeof(struct hpet_hld_data) + cpumask_size());
and used as:
to_cpumask(hhd->cpumask);
next prev parent reply other threads:[~2019-04-09 11:03 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 16:05 [RFC PATCH v2 00/14] Implement an HPET-based hardlockup detector Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 01/14] x86/msi: Add definition for NMI delivery mode Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 02/14] x86/hpet: Expose more functions to read and write registers Ricardo Neri
2019-03-26 21:00 ` Thomas Gleixner
2019-04-09 2:03 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 03/14] x86/hpet: Calculate ticks-per-second in a separate function Ricardo Neri
2019-03-26 21:03 ` Thomas Gleixner
2019-04-09 2:04 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 04/14] x86/hpet: Reserve timer for the HPET hardlockup detector Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 05/14] x86/hpet: Relocate flag definitions to a header file Ricardo Neri
2019-03-26 21:11 ` Thomas Gleixner
2019-04-09 2:04 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 06/14] x86/hpet: Configure the timer used by the hardlockup detector Ricardo Neri
2019-03-26 21:13 ` Thomas Gleixner
2019-04-09 2:04 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 07/14] watchdog/hardlockup: Define a generic function to detect hardlockups Ricardo Neri
2019-02-27 16:05 ` Ricardo Neri
2019-02-27 16:05 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 08/14] watchdog/hardlockup: Decouple the hardlockup detector from perf Ricardo Neri
2019-02-27 16:05 ` Ricardo Neri
2019-02-27 16:05 ` Ricardo Neri
2019-03-26 21:18 ` Thomas Gleixner
2019-03-26 21:18 ` Thomas Gleixner
2019-03-26 21:18 ` Thomas Gleixner
2019-04-09 2:05 ` Ricardo Neri
2019-04-09 2:05 ` Ricardo Neri
2019-04-09 2:05 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation Ricardo Neri
2019-02-27 16:05 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementatio Ricardo Neri
2019-02-27 16:17 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation Paul E. McKenney
2019-02-27 16:17 ` Paul E. McKenney
2019-02-27 16:17 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implement Paul E. McKenney
2019-03-01 1:17 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation Ricardo Neri
2019-03-01 1:17 ` Ricardo Neri
2019-03-01 1:17 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implement Ricardo Neri
2019-03-26 21:20 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation Thomas Gleixner
2019-03-26 21:20 ` Thomas Gleixner
2019-03-26 21:20 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implement Thomas Gleixner
2019-04-09 2:05 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation Ricardo Neri
2019-04-09 2:05 ` Ricardo Neri
2019-04-09 2:05 ` [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implement Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 10/14] kernel/watchdog: Add a function to obtain the watchdog_allowed_mask Ricardo Neri
2019-02-27 16:05 ` Ricardo Neri
2019-02-27 16:05 ` Ricardo Neri
2019-03-26 21:22 ` Thomas Gleixner
2019-03-26 21:22 ` Thomas Gleixner
2019-03-26 21:22 ` Thomas Gleixner
2019-04-09 2:05 ` Ricardo Neri
2019-04-09 2:05 ` Ricardo Neri
2019-04-09 2:05 ` Ricardo Neri
2019-04-09 11:34 ` Peter Zijlstra
2019-04-09 11:34 ` Peter Zijlstra
2019-04-09 11:34 ` Peter Zijlstra
2019-04-11 1:15 ` Ricardo Neri
2019-04-11 1:15 ` Ricardo Neri
2019-04-11 1:15 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 11/14] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector Ricardo Neri
2019-03-26 20:49 ` Thomas Gleixner
2019-04-09 2:02 ` Ricardo Neri
2019-04-09 10:59 ` Peter Zijlstra
2019-04-10 1:13 ` Ricardo Neri
2019-04-05 16:12 ` Suthikulpanit, Suravee
2019-04-09 2:14 ` Ricardo Neri
2019-04-09 11:03 ` Peter Zijlstra [this message]
2019-04-10 1:05 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 12/14] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI Ricardo Neri
2019-03-26 20:55 ` Thomas Gleixner
2019-04-09 2:02 ` Ricardo Neri
2019-04-09 11:28 ` Peter Zijlstra
2019-04-10 1:19 ` Ricardo Neri
2019-04-10 7:01 ` Peter Zijlstra
2019-04-11 1:12 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 13/14] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter Ricardo Neri
2019-03-26 21:29 ` Thomas Gleixner
2019-04-09 2:07 ` Ricardo Neri
2019-02-27 16:05 ` [RFC PATCH v2 14/14] x86/watchdog: Add a shim hardlockup detector Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409110340.GS4038@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi.kleen@intel.com \
--cc=arnd@arndb.de \
--cc=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=clemens@ladisch.de \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nayna@linux.ibm.com \
--cc=ndesaulniers@google.com \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.