From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: per-device dma_map_ops for intel-iommu? Date: Tue, 9 Apr 2019 15:59:24 +0200 Message-ID: <20190409135924.GA11431@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: David Woodhouse , Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org Hi David and Joerg, do you remember a good reason why intel-iommu is not using per-device dma_map_ops like the AMD iommu or the various ARM iommus? Right now intel-iommu.c contains a half-asses reimplementation of the dma direct code for the iommu_no_mapping() case, and it would seem much nicer to just fall back to that case and not even call into intel-iommu in that case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9311DC282CE for ; Tue, 9 Apr 2019 13:59:38 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AA1020883 for ; Tue, 9 Apr 2019 13:59:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AA1020883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 2EBB4FC4; Tue, 9 Apr 2019 13:59:38 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3C1A6FBF for ; Tue, 9 Apr 2019 13:59:37 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E1E9376D for ; Tue, 9 Apr 2019 13:59:36 +0000 (UTC) Received: by newverein.lst.de (Postfix, from userid 2407) id B7C7268B02; Tue, 9 Apr 2019 15:59:24 +0200 (CEST) Date: Tue, 9 Apr 2019 15:59:24 +0200 From: Christoph Hellwig To: David Woodhouse , Joerg Roedel Subject: per-device dma_map_ops for intel-iommu? Message-ID: <20190409135924.GA11431@lst.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190409135924.tKs8W0Sotc1yh4wLovc1K6E2xVxPG38z9q-CJh9xPQ4@z> Hi David and Joerg, do you remember a good reason why intel-iommu is not using per-device dma_map_ops like the AMD iommu or the various ARM iommus? Right now intel-iommu.c contains a half-asses reimplementation of the dma direct code for the iommu_no_mapping() case, and it would seem much nicer to just fall back to that case and not even call into intel-iommu in that case. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu