From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view
Date: Tue, 9 Apr 2019 12:01:38 -0300 [thread overview]
Message-ID: <20190409150138.GC31835@kernel.org> (raw)
In-Reply-To: <20190409062557.26138-1-adrian.hunter@intel.com>
Em Tue, Apr 09, 2019 at 09:25:57AM +0300, Adrian Hunter escreveu:
> Fix following error using calls_view:
> Query failed: ambiguous column name: parent_id Unable to execute statement
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Applied, and thanks for the Fixes tag, appreciated,
- Arnaldo
> Fixes: 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
> ---
> tools/perf/scripts/python/export-to-sqlite.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
> index 3b71902a5a21..bf271fbc3a88 100644
> --- a/tools/perf/scripts/python/export-to-sqlite.py
> +++ b/tools/perf/scripts/python/export-to-sqlite.py
> @@ -331,7 +331,7 @@ if perf_db_export_calls:
> 'return_id,'
> 'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
> 'parent_call_path_id,'
> - 'parent_id'
> + 'calls.parent_id'
> ' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
>
> do_query(query, 'CREATE VIEW samples_view AS '
> --
> 2.17.1
--
- Arnaldo
next prev parent reply other threads:[~2019-04-09 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 6:25 [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view Adrian Hunter
2019-04-09 15:01 ` Arnaldo Carvalho de Melo [this message]
2019-04-12 16:38 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2019-04-16 15:28 ` tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409150138.GC31835@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.