From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/2] memory: ti-emif-sram: Add ti_emif_run_hw_leveling for DDR3 hardware leveling Date: Tue, 9 Apr 2019 08:33:10 -0700 Message-ID: <20190409153310.GK2839@atomide.com> References: <20190402165743.28106-1-d-gerlach@ti.com> <20190402165743.28106-2-d-gerlach@ti.com> <20190402172401.GO49658@atomide.com> <60a33620-0f27-37d8-5d29-dc83ab410274@ti.com> <20190408193400.GO49658@atomide.com> <20190409151905.GJ2839@atomide.com> <92aa0912-d449-c59e-fcf6-3a4b9e15ce3b@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <92aa0912-d449-c59e-fcf6-3a4b9e15ce3b@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "santosh.shilimkar@oracle.com" Cc: Brad Griffis , Dave Gerlach , Keerthy J , Santosh Shilimkar , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org * santosh.shilimkar@oracle.com [190409 15:26]: > On 4/9/19 8:19 AM, Tony Lindgren wrote: > > * Tony Lindgren [190408 19:34]: > > > * Dave Gerlach [190408 18:31]: > > > > Tony, > > > > On 4/2/19 12:24 PM, Tony Lindgren wrote: > > > > > * Dave Gerlach [190402 16:57]: > > > > > > In certain situations, such as when returning from low power modes, the > > > > > > EMIF must re-run hardware leveling to properly restore DDR3 access. > > > > > > > > > > > > This is accomplished by introducing a new ti-emif-sram-pm call, > > > > > > ti_emif_run_hw_leveling, to check if DDR3 is in use and if so, trigger > > > > > > the full write and read leveling processes. > > > > > > > > > > OK nice that you also consider devices with LPDDR2 then in case we > > > > > start seeing those. > > > > > > > > Yes, LPDDR2 will work fine with these. Any thoughts on if this series should > > > > come through you or Santosh? > > > > > > Probably best that I queue these since there's also > > > arch/arm/mach-omap2 code related changes. > > > > Santosh, is this OK with you? Care to ack the patch? > > > Sure Tony !! > > Acked-by: Santosh Shilimkar Thanks, applying these two patches into omap-for-v5.2/am4-ddr3 branch. Reagrds, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9F05C10F0E for ; Tue, 9 Apr 2019 15:33:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 949A9206B7 for ; Tue, 9 Apr 2019 15:33:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fCfa51FY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 949A9206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PjGHcGOjuAybYdWe1Yr7lAcbGbr0vV/e5EmWXHVMLHY=; b=fCfa51FY8u0X1x k4Re+NODb6y5Tk/Qt+pjmnh2PmpiCopS3oBgBzRmsFeHSIZ55TtjItBhs4b+wzkLkfh+huMR7ux3z 36whEGHQtjPb7sfh4Tj/92Hs45gYY04VAvDTn/IYUqAYA7lhfB6z7PonkqoJG/JGb1dJm5BdfVC8i Z8TUCJc4/n0UAPnPTQrtkdVOEdVI/LLAwiU07vHv+oC1NYb54LPtWu20WEEFLd0nYF+NUOfyO1O/W lNM/orxE5Pu/oqTvxudynXzv408t3Dn3q4uffvLdjHoXzz/XOpWYAGLmEY4u61v5acZ3tZlS60EjT 2dyH+Ie+ydSU54GrofIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDskP-0003EA-7r; Tue, 09 Apr 2019 15:33:17 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hDskM-0003Dr-Bx for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2019 15:33:15 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F11498027; Tue, 9 Apr 2019 15:33:28 +0000 (UTC) Date: Tue, 9 Apr 2019 08:33:10 -0700 From: Tony Lindgren To: "santosh.shilimkar@oracle.com" Subject: Re: [PATCH 1/2] memory: ti-emif-sram: Add ti_emif_run_hw_leveling for DDR3 hardware leveling Message-ID: <20190409153310.GK2839@atomide.com> References: <20190402165743.28106-1-d-gerlach@ti.com> <20190402165743.28106-2-d-gerlach@ti.com> <20190402172401.GO49658@atomide.com> <60a33620-0f27-37d8-5d29-dc83ab410274@ti.com> <20190408193400.GO49658@atomide.com> <20190409151905.GJ2839@atomide.com> <92aa0912-d449-c59e-fcf6-3a4b9e15ce3b@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <92aa0912-d449-c59e-fcf6-3a4b9e15ce3b@oracle.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190409_083314_441388_21C15ED1 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brad Griffis , Dave Gerlach , Keerthy J , Santosh Shilimkar , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * santosh.shilimkar@oracle.com [190409 15:26]: > On 4/9/19 8:19 AM, Tony Lindgren wrote: > > * Tony Lindgren [190408 19:34]: > > > * Dave Gerlach [190408 18:31]: > > > > Tony, > > > > On 4/2/19 12:24 PM, Tony Lindgren wrote: > > > > > * Dave Gerlach [190402 16:57]: > > > > > > In certain situations, such as when returning from low power modes, the > > > > > > EMIF must re-run hardware leveling to properly restore DDR3 access. > > > > > > > > > > > > This is accomplished by introducing a new ti-emif-sram-pm call, > > > > > > ti_emif_run_hw_leveling, to check if DDR3 is in use and if so, trigger > > > > > > the full write and read leveling processes. > > > > > > > > > > OK nice that you also consider devices with LPDDR2 then in case we > > > > > start seeing those. > > > > > > > > Yes, LPDDR2 will work fine with these. Any thoughts on if this series should > > > > come through you or Santosh? > > > > > > Probably best that I queue these since there's also > > > arch/arm/mach-omap2 code related changes. > > > > Santosh, is this OK with you? Care to ack the patch? > > > Sure Tony !! > > Acked-by: Santosh Shilimkar Thanks, applying these two patches into omap-for-v5.2/am4-ddr3 branch. Reagrds, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel