From: kbuild test robot <lkp@intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Eric Dumazet <edumazet@google.com>,
Ivan Vecera <ivecera@redhat.com>
Subject: Re: [PATCH net-next 5/5] Revert: "net: sched: put back q.qlen into a single location"
Date: Tue, 9 Apr 2019 17:51:07 +0800 [thread overview]
Message-ID: <201904091737.piuPg5CE%lkp@intel.com> (raw)
In-Reply-To: <033147df6656a912ba311184e55916333b3745b1.1554740883.git.pabeni@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 5434 bytes --]
Hi Paolo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-caif-avoid-using-qdisc_qlen/20190409-164620
config: i386-randconfig-x077-201914 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from include/linux/filter.h:24:0,
from include/net/sock.h:64,
from include/net/cls_cgroup.h:19,
from net/socket.c:99:
include/net/sch_generic.h: In function 'qdisc_all_tx_empty':
include/net/sch_generic.h:748:8: error: implicit declaration of function 'qdisc_is_empty'; did you mean 'ida_is_empty'? [-Werror=implicit-function-declaration]
if (!qdisc_is_empty(q)) {
^~~~~~~~~~~~~~
ida_is_empty
include/net/sch_generic.h: At top level:
include/net/sch_generic.h:823:20: error: conflicting types for 'qdisc_is_empty'
static inline bool qdisc_is_empty(const struct Qdisc *qdisc)
^~~~~~~~~~~~~~
include/net/sch_generic.h:748:8: note: previous implicit declaration of 'qdisc_is_empty' was here
if (!qdisc_is_empty(q)) {
^~~~~~~~~~~~~~
include/net/sch_generic.h: In function 'qdisc_dequeue_peeked':
>> include/net/sch_generic.h:1149:4: error: implicit declaration of function 'qdisc_qstats_atomic_qlen_dec'; did you mean 'qdisc_qstats_cpu_qlen_dec'? [-Werror=implicit-function-declaration]
qdisc_qstats_atomic_qlen_dec(sch);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
qdisc_qstats_cpu_qlen_dec
cc1: some warnings being treated as errors
--
In file included from include/linux/filter.h:24:0,
from include/net/sock.h:64,
from include/net/inet_sock.h:26,
from include/net/inet_connection_sock.h:24,
from include/linux/dccp.h:13,
from net//dccp/proto.c:12:
include/net/sch_generic.h: In function 'qdisc_all_tx_empty':
include/net/sch_generic.h:748:8: error: implicit declaration of function 'qdisc_is_empty'; did you mean 'ida_is_empty'? [-Werror=implicit-function-declaration]
if (!qdisc_is_empty(q)) {
^~~~~~~~~~~~~~
ida_is_empty
include/net/sch_generic.h: At top level:
include/net/sch_generic.h:823:20: error: conflicting types for 'qdisc_is_empty'
static inline bool qdisc_is_empty(const struct Qdisc *qdisc)
^~~~~~~~~~~~~~
include/net/sch_generic.h:748:8: note: previous implicit declaration of 'qdisc_is_empty' was here
if (!qdisc_is_empty(q)) {
^~~~~~~~~~~~~~
include/net/sch_generic.h: In function 'qdisc_dequeue_peeked':
>> include/net/sch_generic.h:1149:4: error: implicit declaration of function 'qdisc_qstats_atomic_qlen_dec'; did you mean 'qdisc_qstats_cpu_qlen_dec'? [-Werror=implicit-function-declaration]
qdisc_qstats_atomic_qlen_dec(sch);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
qdisc_qstats_cpu_qlen_dec
In file included from net//dccp/trace.h:84:0,
from net//dccp/proto.c:42:
include/trace/define_trace.h: At top level:
include/trace/define_trace.h:89:42: fatal error: ./trace.h: No such file or directory
#include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
^
cc1: some warnings being treated as errors
compilation terminated.
vim +1149 include/net/sch_generic.h
fa70e3d2 Paolo Abeni 2019-04-08 1139
77be155c Jarek Poplawski 2008-10-31 1140 /* use instead of qdisc->dequeue() for all qdiscs queried with ->peek() */
77be155c Jarek Poplawski 2008-10-31 1141 static inline struct sk_buff *qdisc_dequeue_peeked(struct Qdisc *sch)
77be155c Jarek Poplawski 2008-10-31 1142 {
a53851e2 John Fastabend 2017-12-07 1143 struct sk_buff *skb = skb_peek(&sch->gso_skb);
77be155c Jarek Poplawski 2008-10-31 1144
61c9eaf9 Jarek Poplawski 2008-11-05 1145 if (skb) {
a53851e2 John Fastabend 2017-12-07 1146 skb = __skb_dequeue(&sch->gso_skb);
9cda4ff7 Paolo Abeni 2019-04-08 1147 if (qdisc_is_percpu_stats(sch)) {
9cda4ff7 Paolo Abeni 2019-04-08 1148 qdisc_qstats_cpu_backlog_dec(sch, skb);
9cda4ff7 Paolo Abeni 2019-04-08 @1149 qdisc_qstats_atomic_qlen_dec(sch);
9cda4ff7 Paolo Abeni 2019-04-08 1150 } else {
a27758ff WANG Cong 2016-06-03 1151 qdisc_qstats_backlog_dec(sch, skb);
61c9eaf9 Jarek Poplawski 2008-11-05 1152 sch->q.qlen--;
9cda4ff7 Paolo Abeni 2019-04-08 1153 }
61c9eaf9 Jarek Poplawski 2008-11-05 1154 } else {
77be155c Jarek Poplawski 2008-10-31 1155 skb = sch->dequeue(sch);
61c9eaf9 Jarek Poplawski 2008-11-05 1156 }
77be155c Jarek Poplawski 2008-10-31 1157
77be155c Jarek Poplawski 2008-10-31 1158 return skb;
77be155c Jarek Poplawski 2008-10-31 1159 }
77be155c Jarek Poplawski 2008-10-31 1160
:::::: The code at line 1149 was first introduced by commit
:::::: 9cda4ff7ed51bb469cb19e03c9fe4972408edb63 net: sched: always do stats accounting according to TCQ_F_CPUSTATS
:::::: TO: Paolo Abeni <pabeni@redhat.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32236 bytes --]
next prev parent reply other threads:[~2019-04-09 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 16:35 [PATCH net-next 0/5] net: sched: move back qlen to per CPU accounting Paolo Abeni
2019-04-08 16:35 ` [PATCH net-next 1/5] net: caif: avoid using qdisc_qlen() Paolo Abeni
2019-04-08 16:35 ` [PATCH net-next 2/5] net: sched: prefer qdisc_is_empty() over direct qlen access Paolo Abeni
2019-04-08 16:35 ` [PATCH net-next 3/5] net: sched: always do stats accounting according to TCQ_F_CPUSTATS Paolo Abeni
2019-04-09 9:50 ` kbuild test robot
2019-04-09 10:41 ` Paolo Abeni
2019-04-09 10:19 ` kbuild test robot
2019-04-08 16:35 ` [PATCH net-next 4/5] net: sched: when clearing NOLOCK, clear TCQ_F_CPUSTATS, too Paolo Abeni
2019-04-08 16:35 ` [PATCH net-next 5/5] Revert: "net: sched: put back q.qlen into a single location" Paolo Abeni
2019-04-08 21:17 ` Eric Dumazet
2019-04-09 7:52 ` Paolo Abeni
2019-04-09 9:51 ` kbuild test robot [this message]
2019-04-09 11:55 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904091737.piuPg5CE%lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ivecera@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.