From: Bharata B Rao <bharata@linux.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Laurent Vivier <lvivier@redhat.com>,
linuxppc-dev@lists.ozlabs.org, aneesh.kumar@linux.vnet.ibm.com,
david@gibson.dropbear.id.au
Subject: Re: [PATCH] powerpc/pseries: Provide verbose info about HPT resizing attempt
Date: Wed, 10 Apr 2019 15:19:13 +0530 [thread overview]
Message-ID: <20190410094913.GA6503@in.ibm.com> (raw)
In-Reply-To: <87h8b66u0q.fsf@concordia.ellerman.id.au>
On Wed, Apr 10, 2019 at 08:20:53PM +1000, Michael Ellerman wrote:
> Bharata B Rao <bharata@linux.ibm.com> writes:
>
> > When HPT resizing is attempted in response to memory hotplug, we see
> > the following messages from the kernel:
> >
> > lpar: Attempting to resize HPT to shift 23
> > Unable to resize hash page table to target order 23: -28
> >
> > This gives a feeling as though we are trying to grow HPT but failed and
> > hence bad things might happen in future. Improve the message a bit
> > by explicitly printing the existing HPT shift value in addtion to
> > the newly targeted value so that it is clear that we haven't failed
> > to grow HPT. After this commit, the same message will appear like this:
> >
> > lpar: Attempting to resize HPT from shift 25 to 23
> > Unable to resize hash page table to target order 23: -28
> >
> > Signed-off-by: Bharata B Rao <bharata@linux.ibm.com>
>
> I'd be inclined to just remove the "Attempting .." message.
>
> But I have this patch from Laurent queued, which already reworks things:
>
> https://patchwork.ozlabs.org/patch/1055996/
>
>
> Does that address your problem?
Yes, I should have seen this earlier.
Regards,
Bharata.
prev parent reply other threads:[~2019-04-10 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 7:55 [PATCH] powerpc/pseries: Provide verbose info about HPT resizing attempt Bharata B Rao
2019-04-10 10:20 ` Michael Ellerman
2019-04-10 9:49 ` Bharata B Rao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410094913.GA6503@in.ibm.com \
--to=bharata@linux.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.