All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ASoC: pcm: fix error handling when try_module_get() fails.
Date: Wed, 10 Apr 2019 10:50:10 +0100	[thread overview]
Message-ID: <20190410095010.GD6106@sirena.org.uk> (raw)
In-Reply-To: <20190408193025.22639-1-ranjani.sridharan@linux.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 481 bytes --]

On Mon, Apr 08, 2019 at 12:30:25PM -0700, Ranjani Sridharan wrote:
> Handle error before returning when try_module_get() fails
> to prevent inconsistent mutex lock/unlock.
> 
> Fixes: 52034add7 (ASoC: pcm: update module refcount if
> 		  module_get_upon_open is set)
> 
> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>

You keep on adding blank lines after your Fixes: lines for some reason,
this is unusual and will probably confuse some tooling.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2019-04-10  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 19:30 [PATCH] ASoC: pcm: fix error handling when try_module_get() fails Ranjani Sridharan
2019-04-10  9:50 ` Mark Brown [this message]
2019-04-10 14:30   ` Ranjani Sridharan
2019-04-10 12:26 ` Applied "ASoC: pcm: fix error handling when try_module_get() fails." to the asoc tree Mark Brown
2019-05-13 12:30 ` Mark Brown
2020-04-15 23:32 ` Mark Brown
2020-04-16 15:24   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190410095010.GD6106@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.