From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 1/4] platform/x86: intel_pmc_ipc: Use BIT() macro Date: Wed, 10 Apr 2019 16:59:13 +0300 Message-ID: <20190410135913.GK9224@smile.fi.intel.com> References: <20190409112515.84725-1-andriy.shevchenko@linux.intel.com> <7bb60283-f99f-679d-4efa-45962ccd68f3@linux.intel.com> <20190409173939.GY9224@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190409173939.GY9224@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: sathyanarayanan kuppuswamy Cc: Darren Hart , platform-driver-x86@vger.kernel.org, Zha Qipeng , junxiao.chang@intel.com, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Tue, Apr 09, 2019 at 08:39:39PM +0300, Andy Shevchenko wrote: > On Tue, Apr 09, 2019 at 10:07:35AM -0700, sathyanarayanan kuppuswamy wrote: > > On 4/9/19 4:25 AM, Andy Shevchenko wrote: > > > Use BIT() and BIT_MASK() macros for definitions. > > Looks good to me. > > Thanks! If you have no further comments, can you provide your tag here? > > > > /* PMC register bit definitions */ > > > /* PMC_CFG_REG bit masks */ > > > -#define PMC_CFG_NO_REBOOT_MASK (1 << 4) > > > +#define PMC_CFG_NO_REBOOT_MASK BIT_MASK(4) > > > #define PMC_CFG_NO_REBOOT_EN (1 << 4) > > > #define PMC_CFG_NO_REBOOT_DIS (0 << 4) > > Do we need 0 << 4 ? > > Yes, to explicitly show that this is a value for NO_REBOOT masked bit(s) > (single bit in this case). > > -- > With Best Regards, > Andy Shevchenko > > -- With Best Regards, Andy Shevchenko