From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH] of: Improve of_phandle_iterator_next() error message
Date: Wed, 10 Apr 2019 09:07:27 -0500 [thread overview]
Message-ID: <20190410140727.GA17374@bogus> (raw)
In-Reply-To: <20190403175633.1839-1-f.fainelli@gmail.com>
On Wed, Apr 03, 2019 at 10:56:33AM -0700, Florian Fainelli wrote:
> Understanding why of_phandle_iterator_next() returns an error can
> sometimes be hard to decipher based solely on the error message, a
> typical error example is that #foo-cells = <X> and the phandle property
> used has a smaller number of cells specified, e.g.:
>
> #thermal-sensor-cells = <1>;
> phandle = <&scmi_sensor>
>
> instead of:
>
> phandle <&scmi_sensor 0>;
>
> Instead, make it clear what the expectations are towards debugging
> incorrect Device Tree faster:
>
> OF: /thermal-zones/scmi-thermal: #thermal-sensor-cells = 1, found 0 instead
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/of/base.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied.
Rob
prev parent reply other threads:[~2019-04-10 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 17:56 [PATCH] of: Improve of_phandle_iterator_next() error message Florian Fainelli
2019-04-03 17:56 ` Florian Fainelli
2019-04-10 14:07 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410140727.GA17374@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.