From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>,
kvm@vger.kernel.org, "Jon Doron" <arilou@gmail.com>,
"Jim Mattson" <jmattson@google.com>,
"Liran Alon" <liran.alon@oracle.com>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>
Subject: Re: [PATCH 1/3] KVM: x86: Load SMRAM in a single shot when leaving SMM
Date: Wed, 10 Apr 2019 07:17:34 -0700 [thread overview]
Message-ID: <20190410141734.GA10760@linux.intel.com> (raw)
In-Reply-To: <86ae2c55-d2ce-141d-7e8c-64724c3c1694@redhat.com>
On Wed, Apr 10, 2019 at 11:19:19AM +0200, Paolo Bonzini wrote:
> On 02/04/19 17:03, Sean Christopherson wrote:
> > Ostensibly, the only motivation for having HF_SMM_MASK set throughout
> > the loading of state from the SMRAM save state area is so that the
> > memory accesses from GET_SMSTATE() are tagged with role.smm (though
> > arguably even that is unnecessary).
>
> Why is that unnecessary? If they do not have role.smm they would access
> video RAM or TSEG, not the state save area.
You're right, feel free to strike that line from the record. For some
reason I had it in my mind that enter_smm() was writing SMRAM before
setting HF_SMM_MASK.
next prev parent reply other threads:[~2019-04-10 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190402150311.29481-1-sean.j.christopherson@intel.com>
[not found] ` <20190402150311.29481-2-sean.j.christopherson@intel.com>
2019-04-10 9:19 ` [PATCH 1/3] KVM: x86: Load SMRAM in a single shot when leaving SMM Paolo Bonzini
2019-04-10 14:17 ` Sean Christopherson [this message]
2019-04-10 9:25 ` [PATCH 0/3] KVM: x86: clear HF_SMM_MASK before loading state Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410141734.GA10760@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=arilou@gmail.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.