From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A2F4C10F11 for ; Wed, 10 Apr 2019 14:29:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 482DE20854 for ; Wed, 10 Apr 2019 14:29:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SfU2+L9g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 482DE20854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HWiR7Ky74Uhts74lmpVJhXCFfTx8SuhRq2Lfn+X3t5I=; b=SfU2+L9gnbdRJv 889pmA0g8VS84oV4WOZgVghmm4kIVh6Zbnn9Yy8ApMIoF5ecZP0sijJplhI9IYFCUL2Scybc8yKWa UUdbjBw2RPg/68V4uZhGnNaxE7LqwTZ3/veUJIAQ8PrlxDFBF4bUyOEthhIr1AXvIdtC/f+jfZGsv Nc/1GNepEvhQAGIjyc08l8H5tttQlc0EXFaE7arOYercc9FJ46s9leul8GCKpAKJbgmc8EmHrePnk Ff3KaxViPnjCX/2D7EwAtjJ1CMT8KuJe2D4CIRyWg03U+773X1E0tkv04zBZG4DP4ZdEYWNluYNzs AseBrN7RraPcqLHo6C3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEEEK-0005uH-3r; Wed, 10 Apr 2019 14:29:36 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEEEG-0005tr-7O for linux-mtd@lists.infradead.org; Wed, 10 Apr 2019 14:29:34 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 886E128245E; Wed, 10 Apr 2019 15:29:30 +0100 (BST) Date: Wed, 10 Apr 2019 16:29:27 +0200 From: Boris Brezillon To: YueHaibing Subject: Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module Message-ID: <20190410162927.17ea678b@collabora.com> In-Reply-To: <8b020124-4008-6081-c04c-eaefb7875878@huawei.com> References: <20190410130747.35692-1-yuehaibing@huawei.com> <20190410153920.68267a1a@collabora.com> <20190410155856.655122c8@collabora.com> <8b020124-4008-6081-c04c-eaefb7875878@huawei.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190410_072932_554909_319312F6 X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bbrezillon@kernel.org, richard@nod.at, linux-kernel@vger.kernel.org, marek.vasut@gmail.com, paul.burton@mips.com, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, computersforpeace@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, 10 Apr 2019 22:22:16 +0800 YueHaibing wrote: > On 2019/4/10 21:58, Boris Brezillon wrote: > > On Wed, 10 Apr 2019 15:39:28 +0200 > > Boris Brezillon wrote: > > > >> On Wed, 10 Apr 2019 21:07:47 +0800 > >> Yue Haibing wrote: > >> > >>> From: YueHaibing > >>> > >>> Fix gcc build error while CONFIG_MTD_NAND_ECC_SW_BCH > >>> is set to module: > >>> > >>> drivers/mtd/nand/raw/nand_base.o: In function `nand_cleanup': > >>> (.text+0xef6): undefined reference to `nand_bch_free' > >>> drivers/mtd/nand/raw/nand_base.o: In function `nand_scan_tail': > >>> nand_base.c:(.text+0xa101): undefined reference to `nand_bch_calculate_ecc' > >>> nand_base.c:(.text+0xa120): undefined reference to `nand_bch_correct_data' > >>> nand_base.c:(.text+0xa269): undefined reference to `nand_bch_init' > >>> > >>> CONFIG_MTD_NAND_ECC_SW_BCH should not be set to M, > >>> because MTD_RAW_NAND need it while linked. > >>> > >>> Reported-by: Hulk Robot > >>> Fixes: 193bd4002644 ("mtd: nand: add software BCH ECC support" > >> > >> Nope, it's not this one that introduced the regression. > >> > >> > >> > >>> Signed-off-by: YueHaibing > >>> --- > >>> drivers/mtd/nand/raw/Kconfig | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > >>> index 615d738..0500c42 100644 > >>> --- a/drivers/mtd/nand/raw/Kconfig > >>> +++ b/drivers/mtd/nand/raw/Kconfig > >>> @@ -22,7 +22,7 @@ menuconfig MTD_RAW_NAND > >>> if MTD_RAW_NAND > >>> > >>> config MTD_NAND_ECC_SW_BCH > >>> - tristate "Support software BCH ECC" > >>> + bool "Support software BCH ECC" > >>> select BCH > >>> default n > >>> help > >> > >> Should be fixed with the following diff squashed into: > >> > >> 51ef1d0b2095 ("mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm") > >> > >> --->8--- > >> diff --git a/include/linux/mtd/nand_bch.h b/include/linux/mtd/nand_bch.h > >> index b8106651f807..06ce2b655c13 100644 > >> --- a/include/linux/mtd/nand_bch.h > >> +++ b/include/linux/mtd/nand_bch.h > >> @@ -15,7 +15,7 @@ struct mtd_info; > >> struct nand_chip; > >> struct nand_bch_control; > >> > >> -#if defined(CONFIG_MTD_NAND_ECC_BCH) > >> +#if defined(CONFIG_MTD_NAND_ECC_SW_BCH) > >> > >> static inline int mtd_nand_has_bch(void) { return 1; } > >> > >> @@ -39,7 +39,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd); > >> */ > >> void nand_bch_free(struct nand_bch_control *nbc); > >> > >> -#else /* !CONFIG_MTD_NAND_ECC_BCH */ > >> +#else /* !CONFIG_MTD_NAND_ECC_SW_BCH */ > >> > >> static inline int mtd_nand_has_bch(void) { return 0; } > >> > >> @@ -64,6 +64,6 @@ static inline struct nand_bch_control *nand_bch_init(struct mtd_info *mtd) > >> > >> static inline void nand_bch_free(struct nand_bch_control *nbc) {} > >> > >> -#endif /* CONFIG_MTD_NAND_ECC_BCH */ > >> +#endif /* CONFIG_MTD_NAND_ECC_SW_BCH */ > >> > >> #endif /* __MTD_NAND_BCH_H__ */ > > > > Sorry, I didn't look at the right branch, this part of the code was > > correct, but we still have a problem to express the RAW_NAND(y) -> > > SW_BCH(y) dependency. > > It seems this dependency is not always need, > > case MTD_RAW_NAND set to y works well while CONFIG_MTD_NAND_ECC_SW_BCH is not set. Yes, I know, but forcing nand_bch to a be a boolean is not the right solution either, hence my suggestion to use 'imply'. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F926C10F14 for ; Wed, 10 Apr 2019 14:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79E5620850 for ; Wed, 10 Apr 2019 14:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732780AbfDJO3d (ORCPT ); Wed, 10 Apr 2019 10:29:33 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:54634 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732639AbfDJO3d (ORCPT ); Wed, 10 Apr 2019 10:29:33 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 886E128245E; Wed, 10 Apr 2019 15:29:30 +0100 (BST) Date: Wed, 10 Apr 2019 16:29:27 +0200 From: Boris Brezillon To: YueHaibing Cc: , , , , , , , Subject: Re: [PATCH] mtd: nand: Fix build error while CONFIG_MTD_NAND_ECC_SW_BCH is set to module Message-ID: <20190410162927.17ea678b@collabora.com> In-Reply-To: <8b020124-4008-6081-c04c-eaefb7875878@huawei.com> References: <20190410130747.35692-1-yuehaibing@huawei.com> <20190410153920.68267a1a@collabora.com> <20190410155856.655122c8@collabora.com> <8b020124-4008-6081-c04c-eaefb7875878@huawei.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Apr 2019 22:22:16 +0800 YueHaibing wrote: > On 2019/4/10 21:58, Boris Brezillon wrote: > > On Wed, 10 Apr 2019 15:39:28 +0200 > > Boris Brezillon wrote: > > > >> On Wed, 10 Apr 2019 21:07:47 +0800 > >> Yue Haibing wrote: > >> > >>> From: YueHaibing > >>> > >>> Fix gcc build error while CONFIG_MTD_NAND_ECC_SW_BCH > >>> is set to module: > >>> > >>> drivers/mtd/nand/raw/nand_base.o: In function `nand_cleanup': > >>> (.text+0xef6): undefined reference to `nand_bch_free' > >>> drivers/mtd/nand/raw/nand_base.o: In function `nand_scan_tail': > >>> nand_base.c:(.text+0xa101): undefined reference to `nand_bch_calculate_ecc' > >>> nand_base.c:(.text+0xa120): undefined reference to `nand_bch_correct_data' > >>> nand_base.c:(.text+0xa269): undefined reference to `nand_bch_init' > >>> > >>> CONFIG_MTD_NAND_ECC_SW_BCH should not be set to M, > >>> because MTD_RAW_NAND need it while linked. > >>> > >>> Reported-by: Hulk Robot > >>> Fixes: 193bd4002644 ("mtd: nand: add software BCH ECC support" > >> > >> Nope, it's not this one that introduced the regression. > >> > >> > >> > >>> Signed-off-by: YueHaibing > >>> --- > >>> drivers/mtd/nand/raw/Kconfig | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > >>> index 615d738..0500c42 100644 > >>> --- a/drivers/mtd/nand/raw/Kconfig > >>> +++ b/drivers/mtd/nand/raw/Kconfig > >>> @@ -22,7 +22,7 @@ menuconfig MTD_RAW_NAND > >>> if MTD_RAW_NAND > >>> > >>> config MTD_NAND_ECC_SW_BCH > >>> - tristate "Support software BCH ECC" > >>> + bool "Support software BCH ECC" > >>> select BCH > >>> default n > >>> help > >> > >> Should be fixed with the following diff squashed into: > >> > >> 51ef1d0b2095 ("mtd: nand: Clarify Kconfig entry for software BCH ECC algorithm") > >> > >> --->8--- > >> diff --git a/include/linux/mtd/nand_bch.h b/include/linux/mtd/nand_bch.h > >> index b8106651f807..06ce2b655c13 100644 > >> --- a/include/linux/mtd/nand_bch.h > >> +++ b/include/linux/mtd/nand_bch.h > >> @@ -15,7 +15,7 @@ struct mtd_info; > >> struct nand_chip; > >> struct nand_bch_control; > >> > >> -#if defined(CONFIG_MTD_NAND_ECC_BCH) > >> +#if defined(CONFIG_MTD_NAND_ECC_SW_BCH) > >> > >> static inline int mtd_nand_has_bch(void) { return 1; } > >> > >> @@ -39,7 +39,7 @@ struct nand_bch_control *nand_bch_init(struct mtd_info *mtd); > >> */ > >> void nand_bch_free(struct nand_bch_control *nbc); > >> > >> -#else /* !CONFIG_MTD_NAND_ECC_BCH */ > >> +#else /* !CONFIG_MTD_NAND_ECC_SW_BCH */ > >> > >> static inline int mtd_nand_has_bch(void) { return 0; } > >> > >> @@ -64,6 +64,6 @@ static inline struct nand_bch_control *nand_bch_init(struct mtd_info *mtd) > >> > >> static inline void nand_bch_free(struct nand_bch_control *nbc) {} > >> > >> -#endif /* CONFIG_MTD_NAND_ECC_BCH */ > >> +#endif /* CONFIG_MTD_NAND_ECC_SW_BCH */ > >> > >> #endif /* __MTD_NAND_BCH_H__ */ > > > > Sorry, I didn't look at the right branch, this part of the code was > > correct, but we still have a problem to express the RAW_NAND(y) -> > > SW_BCH(y) dependency. > > It seems this dependency is not always need, > > case MTD_RAW_NAND set to y works well while CONFIG_MTD_NAND_ECC_SW_BCH is not set. Yes, I know, but forcing nand_bch to a be a boolean is not the right solution either, hence my suggestion to use 'imply'.