From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH RFC 0/6] nvme: introduce a new flag NVME_ADMIN_QID
Date: Wed, 10 Apr 2019 11:12:16 -0600 [thread overview]
Message-ID: <20190410171215.GD3714@localhost.localdomain> (raw)
In-Reply-To: <20190410080035.82529-1-yuyufen@huawei.com>
On Wed, Apr 10, 2019@01:00:29AM -0700, Yufen Yu wrote:
> Hi, all
>
> This patchset introduces a new flag NVME_ADMIN_QID for admin queue.
> Now that, all drivers in host or target are use index '0' as admin
> queues. Thus, we can use a flag NVME_ADMIN_QID instead of using '0',
> which can make code more easy to read and understand.
>
> This patchset is RFC, and it just use NVME_ADMIN_QID for drivers in
> nvme host. I am not sure whether this patchset actually make sense.
> Any suggestion is welcome and thanks in advance.
IMO, this makes it harder to read anything that's using the 0 index in a
loop.
next prev parent reply other threads:[~2019-04-10 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 8:00 [PATCH RFC 0/6] nvme: introduce a new flag NVME_ADMIN_QID Yufen Yu
2019-04-10 8:00 ` [PATCH RFC 1/6] nvme: add new flags NVME_ADMIN_QID for nvme admin queue Yufen Yu
2019-04-10 16:54 ` Heitke, Kenneth
2019-04-10 8:00 ` [PATCH RFC 2/6] nvme-pci: use NVME_ADMIN_QID for " Yufen Yu
2019-04-10 8:00 ` [PATCH RFC 3/6] nvme-rdma: use flag " Yufen Yu
2019-04-10 8:00 ` [PATCH RFC 4/6] nvme-tcp: " Yufen Yu
2019-04-10 8:00 ` [PATCH RFC 5/6] nvme-fc: " Yufen Yu
2019-04-10 16:52 ` Heitke, Kenneth
2019-04-10 8:00 ` [PATCH RFC 6/6] nvme-fabrics: use flag NVME_ADMIN_QID Yufen Yu
2019-04-10 17:12 ` Keith Busch [this message]
2019-04-10 18:39 ` [PATCH RFC 0/6] nvme: introduce a new " Chaitanya Kulkarni
2019-04-24 16:41 ` Sagi Grimberg
2019-04-10 20:14 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410171215.GD3714@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.