From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver Date: Wed, 10 Apr 2019 18:52:41 +0200 Message-ID: <20190410185241.1b0b1982.cohuck@redhat.com> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-3-pagupta@redhat.com> <20190410091216-mutt-send-email-mst@kernel.org> <127904196.20807948.1554904981681.JavaMail.zimbra@redhat.com> <20190410163139.4a04175e.cohuck@redhat.com> <20190410124114-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190410124114-mutt-send-email-mst@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: "Michael S. Tsirkin" Cc: Pankaj Gupta , jack@suse.cz, kvm@vger.kernel.org, david@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, dave jiang , linux-nvdimm@lists.01.org, vishal l verma , willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval shaia , stefanha@redhat.com, pbonzini@redhat.com, dan j williams , lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric List-Id: linux-acpi@vger.kernel.org On Wed, 10 Apr 2019 12:46:12 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 10, 2019 at 04:31:39PM +0200, Cornelia Huck wrote: > > On Wed, 10 Apr 2019 10:03:01 -0400 (EDT) > > Pankaj Gupta wrote: > > > > > > > > > > On Wed, Apr 10, 2019 at 09:38:22AM +0530, Pankaj Gupta wrote: > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > > > > > Guest reads the persistent memory range information from > > > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > > > > creates a nd_region object with the persistent memory > > > > > range information so that existing 'nvdimm/pmem' driver > > > > > can reserve this into system memory map. This way > > > > > 'virtio-pmem' driver uses existing functionality of pmem > > > > > driver to register persistent memory compatible for DAX > > > > > capable filesystems. > > > > > > > > > > This also provides function to perform guest flush over > > > > > VIRTIO from 'pmem' driver when userspace performs flush > > > > > on DAX memory range. > > > > > > > > > > Signed-off-by: Pankaj Gupta > > > > > > > diff --git a/include/uapi/linux/virtio_ids.h > > > > > b/include/uapi/linux/virtio_ids.h > > > > > index 6d5c3b2d4f4d..346389565ac1 100644 > > > > > --- a/include/uapi/linux/virtio_ids.h > > > > > +++ b/include/uapi/linux/virtio_ids.h > > > > > @@ -43,5 +43,6 @@ > > > > > #define VIRTIO_ID_INPUT 18 /* virtio input */ > > > > > #define VIRTIO_ID_VSOCK 19 /* virtio vsock transport */ > > > > > #define VIRTIO_ID_CRYPTO 20 /* virtio crypto */ > > > > > +#define VIRTIO_ID_PMEM 25 /* virtio pmem */ > > > > > > > > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > > > > > > > Didn't Paolo point out someone is using 25 for audio? > > > > > > > > > Sorry! I did not notice this. > > > > > > > > > > > Please, reserve an ID with the Virtio TC before using it. > > > > > > I thought I requested[1] ID 25. > > > > > > [1] https://github.com/oasis-tcs/virtio-spec/issues/38 > > > [2] https://lists.oasis-open.org/archives/virtio-dev/201805/threads.html > > > > > > In that case I will send request for next available ID i.e 26? > > > > Have the folks using this for audio sent a reservation request as well? > > If not, I'd say the first requester should get the id... > > No but I think they ship their's already. No one ships pmem > so it's less pain for everyone if we just skip 25. Ugh. Ok, then we should change pmem... > > > (And yes, we need to be quicker with voting on/applying id > > reservations :/) > > We can't vote on what was not proposed for a vote. > At the moment that responsibility is with the commented > once discussion on the comment has taken place. > > I think what's missing is a description of the process > in the README. Want to write it up and post it? I can add that to my TODO list, can't promise speedy resolution, though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D695C10F11 for ; Wed, 10 Apr 2019 16:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D351217F4 for ; Wed, 10 Apr 2019 16:53:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388115AbfDJQxF (ORCPT ); Wed, 10 Apr 2019 12:53:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59608 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730479AbfDJQxF (ORCPT ); Wed, 10 Apr 2019 12:53:05 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F5B38046D; Wed, 10 Apr 2019 16:53:04 +0000 (UTC) Received: from gondolin (ovpn-204-33.brq.redhat.com [10.40.204.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CC6A104C421; Wed, 10 Apr 2019 16:52:45 +0000 (UTC) Date: Wed, 10 Apr 2019 18:52:41 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: Pankaj Gupta , jack@suse.cz, kvm@vger.kernel.org, david@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, dave jiang , linux-nvdimm@lists.01.org, vishal l verma , willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval shaia , stefanha@redhat.com, pbonzini@redhat.com, dan j williams , lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric , darrick wong , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, imammedo@redhat.com Subject: Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver Message-ID: <20190410185241.1b0b1982.cohuck@redhat.com> In-Reply-To: <20190410124114-mutt-send-email-mst@kernel.org> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-3-pagupta@redhat.com> <20190410091216-mutt-send-email-mst@kernel.org> <127904196.20807948.1554904981681.JavaMail.zimbra@redhat.com> <20190410163139.4a04175e.cohuck@redhat.com> <20190410124114-mutt-send-email-mst@kernel.org> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 10 Apr 2019 16:53:04 +0000 (UTC) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190410165241.IQuyc0Yen3YlSo6SaIX7TnbG9tr2Vsih6t2xyoJjAOM@z> On Wed, 10 Apr 2019 12:46:12 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 10, 2019 at 04:31:39PM +0200, Cornelia Huck wrote: > > On Wed, 10 Apr 2019 10:03:01 -0400 (EDT) > > Pankaj Gupta wrote: > > > > > > > > > > On Wed, Apr 10, 2019 at 09:38:22AM +0530, Pankaj Gupta wrote: > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > > > > > Guest reads the persistent memory range information from > > > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > > > > creates a nd_region object with the persistent memory > > > > > range information so that existing 'nvdimm/pmem' driver > > > > > can reserve this into system memory map. This way > > > > > 'virtio-pmem' driver uses existing functionality of pmem > > > > > driver to register persistent memory compatible for DAX > > > > > capable filesystems. > > > > > > > > > > This also provides function to perform guest flush over > > > > > VIRTIO from 'pmem' driver when userspace performs flush > > > > > on DAX memory range. > > > > > > > > > > Signed-off-by: Pankaj Gupta > > > > > > > diff --git a/include/uapi/linux/virtio_ids.h > > > > > b/include/uapi/linux/virtio_ids.h > > > > > index 6d5c3b2d4f4d..346389565ac1 100644 > > > > > --- a/include/uapi/linux/virtio_ids.h > > > > > +++ b/include/uapi/linux/virtio_ids.h > > > > > @@ -43,5 +43,6 @@ > > > > > #define VIRTIO_ID_INPUT 18 /* virtio input */ > > > > > #define VIRTIO_ID_VSOCK 19 /* virtio vsock transport */ > > > > > #define VIRTIO_ID_CRYPTO 20 /* virtio crypto */ > > > > > +#define VIRTIO_ID_PMEM 25 /* virtio pmem */ > > > > > > > > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > > > > > > > Didn't Paolo point out someone is using 25 for audio? > > > > > > > > > Sorry! I did not notice this. > > > > > > > > > > > Please, reserve an ID with the Virtio TC before using it. > > > > > > I thought I requested[1] ID 25. > > > > > > [1] https://github.com/oasis-tcs/virtio-spec/issues/38 > > > [2] https://lists.oasis-open.org/archives/virtio-dev/201805/threads.html > > > > > > In that case I will send request for next available ID i.e 26? > > > > Have the folks using this for audio sent a reservation request as well? > > If not, I'd say the first requester should get the id... > > No but I think they ship their's already. No one ships pmem > so it's less pain for everyone if we just skip 25. Ugh. Ok, then we should change pmem... > > > (And yes, we need to be quicker with voting on/applying id > > reservations :/) > > We can't vote on what was not proposed for a vote. > At the moment that responsibility is with the commented > once discussion on the comment has taken place. > > I think what's missing is a description of the process > in the README. Want to write it up and post it? I can add that to my TODO list, can't promise speedy resolution, though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ADF8C211EC670 for ; Wed, 10 Apr 2019 09:53:05 -0700 (PDT) Date: Wed, 10 Apr 2019 18:52:41 +0200 From: Cornelia Huck Subject: Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver Message-ID: <20190410185241.1b0b1982.cohuck@redhat.com> In-Reply-To: <20190410124114-mutt-send-email-mst@kernel.org> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-3-pagupta@redhat.com> <20190410091216-mutt-send-email-mst@kernel.org> <127904196.20807948.1554904981681.JavaMail.zimbra@redhat.com> <20190410163139.4a04175e.cohuck@redhat.com> <20190410124114-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Michael S. Tsirkin" Cc: jack@suse.cz, kvm@vger.kernel.org, david@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, linux-nvdimm@lists.01.org, willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval shaia , stefanha@redhat.com, imammedo@redhat.com, lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric , darrick wong , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, pbonzini@redhat.com List-ID: On Wed, 10 Apr 2019 12:46:12 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 10, 2019 at 04:31:39PM +0200, Cornelia Huck wrote: > > On Wed, 10 Apr 2019 10:03:01 -0400 (EDT) > > Pankaj Gupta wrote: > > > > > > > > > > On Wed, Apr 10, 2019 at 09:38:22AM +0530, Pankaj Gupta wrote: > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > > > > > Guest reads the persistent memory range information from > > > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > > > > creates a nd_region object with the persistent memory > > > > > range information so that existing 'nvdimm/pmem' driver > > > > > can reserve this into system memory map. This way > > > > > 'virtio-pmem' driver uses existing functionality of pmem > > > > > driver to register persistent memory compatible for DAX > > > > > capable filesystems. > > > > > > > > > > This also provides function to perform guest flush over > > > > > VIRTIO from 'pmem' driver when userspace performs flush > > > > > on DAX memory range. > > > > > > > > > > Signed-off-by: Pankaj Gupta > > > > > > > diff --git a/include/uapi/linux/virtio_ids.h > > > > > b/include/uapi/linux/virtio_ids.h > > > > > index 6d5c3b2d4f4d..346389565ac1 100644 > > > > > --- a/include/uapi/linux/virtio_ids.h > > > > > +++ b/include/uapi/linux/virtio_ids.h > > > > > @@ -43,5 +43,6 @@ > > > > > #define VIRTIO_ID_INPUT 18 /* virtio input */ > > > > > #define VIRTIO_ID_VSOCK 19 /* virtio vsock transport */ > > > > > #define VIRTIO_ID_CRYPTO 20 /* virtio crypto */ > > > > > +#define VIRTIO_ID_PMEM 25 /* virtio pmem */ > > > > > > > > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > > > > > > > Didn't Paolo point out someone is using 25 for audio? > > > > > > > > > Sorry! I did not notice this. > > > > > > > > > > > Please, reserve an ID with the Virtio TC before using it. > > > > > > I thought I requested[1] ID 25. > > > > > > [1] https://github.com/oasis-tcs/virtio-spec/issues/38 > > > [2] https://lists.oasis-open.org/archives/virtio-dev/201805/threads.html > > > > > > In that case I will send request for next available ID i.e 26? > > > > Have the folks using this for audio sent a reservation request as well? > > If not, I'd say the first requester should get the id... > > No but I think they ship their's already. No one ships pmem > so it's less pain for everyone if we just skip 25. Ugh. Ok, then we should change pmem... > > > (And yes, we need to be quicker with voting on/applying id > > reservations :/) > > We can't vote on what was not proposed for a vote. > At the moment that responsibility is with the commented > once discussion on the comment has taken place. > > I think what's missing is a description of the process > in the README. Want to write it up and post it? I can add that to my TODO list, can't promise speedy resolution, though. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5A4C10F11 for ; Wed, 10 Apr 2019 16:54:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F59D20820 for ; Wed, 10 Apr 2019 16:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F59D20820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:34700 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEGU9-0005Bw-CV for qemu-devel@archiver.kernel.org; Wed, 10 Apr 2019 12:54:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEGTD-0004kz-Ne for qemu-devel@nongnu.org; Wed, 10 Apr 2019 12:53:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEGTC-0006KF-5M for qemu-devel@nongnu.org; Wed, 10 Apr 2019 12:53:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40076) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEGTB-0006If-RE for qemu-devel@nongnu.org; Wed, 10 Apr 2019 12:53:06 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5F5B38046D; Wed, 10 Apr 2019 16:53:04 +0000 (UTC) Received: from gondolin (ovpn-204-33.brq.redhat.com [10.40.204.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CC6A104C421; Wed, 10 Apr 2019 16:52:45 +0000 (UTC) Date: Wed, 10 Apr 2019 18:52:41 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Message-ID: <20190410185241.1b0b1982.cohuck@redhat.com> In-Reply-To: <20190410124114-mutt-send-email-mst@kernel.org> References: <20190410040826.24371-1-pagupta@redhat.com> <20190410040826.24371-3-pagupta@redhat.com> <20190410091216-mutt-send-email-mst@kernel.org> <127904196.20807948.1554904981681.JavaMail.zimbra@redhat.com> <20190410163139.4a04175e.cohuck@redhat.com> <20190410124114-mutt-send-email-mst@kernel.org> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 10 Apr 2019 16:53:04 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v5 2/5] virtio-pmem: Add virtio pmem driver X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pankaj Gupta , jack@suse.cz, kvm@vger.kernel.org, david@redhat.com, jasowang@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, adilger kernel , zwisler@kernel.org, aarcange@redhat.com, dave jiang , linux-nvdimm@lists.01.org, vishal l verma , willy@infradead.org, hch@infradead.org, linux-acpi@vger.kernel.org, jmoyer@redhat.com, linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl, riel@surriel.com, yuval shaia , stefanha@redhat.com, imammedo@redhat.com, dan j williams , lcapitulino@redhat.com, kwolf@redhat.com, nilal@redhat.com, tytso@mit.edu, xiaoguangrong eric , darrick wong , rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190410165241.ikfNGBEdlZhv6Zkez5V0mz6YGjsNvJAILJicUv7aCQM@z> On Wed, 10 Apr 2019 12:46:12 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 10, 2019 at 04:31:39PM +0200, Cornelia Huck wrote: > > On Wed, 10 Apr 2019 10:03:01 -0400 (EDT) > > Pankaj Gupta wrote: > > > > > > > > > > On Wed, Apr 10, 2019 at 09:38:22AM +0530, Pankaj Gupta wrote: > > > > > This patch adds virtio-pmem driver for KVM guest. > > > > > > > > > > Guest reads the persistent memory range information from > > > > > Qemu over VIRTIO and registers it on nvdimm_bus. It also > > > > > creates a nd_region object with the persistent memory > > > > > range information so that existing 'nvdimm/pmem' driver > > > > > can reserve this into system memory map. This way > > > > > 'virtio-pmem' driver uses existing functionality of pmem > > > > > driver to register persistent memory compatible for DAX > > > > > capable filesystems. > > > > > > > > > > This also provides function to perform guest flush over > > > > > VIRTIO from 'pmem' driver when userspace performs flush > > > > > on DAX memory range. > > > > > > > > > > Signed-off-by: Pankaj Gupta > > > > > > > diff --git a/include/uapi/linux/virtio_ids.h > > > > > b/include/uapi/linux/virtio_ids.h > > > > > index 6d5c3b2d4f4d..346389565ac1 100644 > > > > > --- a/include/uapi/linux/virtio_ids.h > > > > > +++ b/include/uapi/linux/virtio_ids.h > > > > > @@ -43,5 +43,6 @@ > > > > > #define VIRTIO_ID_INPUT 18 /* virtio input */ > > > > > #define VIRTIO_ID_VSOCK 19 /* virtio vsock transport */ > > > > > #define VIRTIO_ID_CRYPTO 20 /* virtio crypto */ > > > > > +#define VIRTIO_ID_PMEM 25 /* virtio pmem */ > > > > > > > > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > > > > > > > Didn't Paolo point out someone is using 25 for audio? > > > > > > > > > Sorry! I did not notice this. > > > > > > > > > > > Please, reserve an ID with the Virtio TC before using it. > > > > > > I thought I requested[1] ID 25. > > > > > > [1] https://github.com/oasis-tcs/virtio-spec/issues/38 > > > [2] https://lists.oasis-open.org/archives/virtio-dev/201805/threads.html > > > > > > In that case I will send request for next available ID i.e 26? > > > > Have the folks using this for audio sent a reservation request as well? > > If not, I'd say the first requester should get the id... > > No but I think they ship their's already. No one ships pmem > so it's less pain for everyone if we just skip 25. Ugh. Ok, then we should change pmem... > > > (And yes, we need to be quicker with voting on/applying id > > reservations :/) > > We can't vote on what was not proposed for a vote. > At the moment that responsibility is with the commented > once discussion on the comment has taken place. > > I think what's missing is a description of the process > in the README. Want to write it up and post it? I can add that to my TODO list, can't promise speedy resolution, though.