From: Bjorn Helgaas <helgaas@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@01.org,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
kbuild-all@01.org, linux-pci@vger.kernel.org,
Robin Murphy <robin.murphy@arm.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [pci:pci/enumeration 6/6] drivers/pci/of.c:40 pci_set_bus_of_node() error: we previously assumed 'bus->self' could be null (see line 34)
Date: Wed, 10 Apr 2019 16:21:12 -0500 [thread overview]
Message-ID: <20190410212112.GH256045@google.com> (raw)
In-Reply-To: <20190410194901.GE31633@kadam>
On Wed, Apr 10, 2019 at 10:49:01PM +0300, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/enumeration
> head: 60ea7f5dd97ed9949e6fbf67e93c9b2c38cc9eb7
> commit: 60ea7f5dd97ed9949e6fbf67e93c9b2c38cc9eb7 [6/6] PCI: OF: Support "external-facing" property
>
> smatch warnings:
> drivers/pci/of.c:40 pci_set_bus_of_node() error: we previously assumed 'bus->self' could be null (see line 34)
Yep, that looks like a problem. I dropped these for now:
60ea7f5dd97e PCI: OF: Support "external-facing" property
6201cf80200c dt-bindings: Add "external-facing" PCIe port property
> # https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?id=60ea7f5dd97ed9949e6fbf67e93c9b2c38cc9eb7
> git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git
> git remote update pci
> git checkout 60ea7f5dd97ed9949e6fbf67e93c9b2c38cc9eb7
> vim +40 drivers/pci/of.c
>
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 31
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 32 void pci_set_bus_of_node(struct pci_bus *bus)
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 33 {
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 @34 if (bus->self == NULL)
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 35 bus->dev.of_node = pcibios_get_phb_of_node(bus);
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 36 else
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 37 bus->dev.of_node = of_node_get(bus->self->dev.of_node);
> 60ea7f5dd9 Jean-Philippe Brucker 2019-04-02 38
> 60ea7f5dd9 Jean-Philippe Brucker 2019-04-02 39 if (of_get_property(bus->dev.of_node, "external-facing", NULL))
> 60ea7f5dd9 Jean-Philippe Brucker 2019-04-02 @40 bus->self->untrusted = true;
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 41 }
> 98d9f30c82 Benjamin Herrenschmidt 2011-04-11 42
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-04-10 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 19:49 [pci:pci/enumeration 6/6] drivers/pci/of.c:40 pci_set_bus_of_node() error: we previously assumed 'bus->self' could be null (see line 34) Dan Carpenter
2019-04-10 21:21 ` Bjorn Helgaas [this message]
2019-04-10 21:59 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410212112.GH256045@google.com \
--to=helgaas@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=grant.likely@linaro.org \
--cc=jean-philippe.brucker@arm.com \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=linux-pci@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.