From: Shawn Guo <shawnguo@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Leo Li <leoyang.li@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: add fsl-dpaa2-console node for DPAA2 platforms
Date: Thu, 11 Apr 2019 10:05:30 +0800 [thread overview]
Message-ID: <20190411020528.GH26817@dragon> (raw)
In-Reply-To: <1553628194-25119-2-git-send-email-ioana.ciornei@nxp.com>
On Tue, Mar 26, 2019 at 07:23:29PM +0000, Ioana Ciornei wrote:
> Add the fsl-dpaa2-console device tree node for the following
> DPAA2 based platforms: LS1088A, LS2080A, LS2088A and LX2160A.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 +++++
> arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 5 +++++
> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index de93b42b1f51..5eee5db3ed6c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -571,6 +571,11 @@
> clock-names = "apb_pclk", "wdog_clk";
> };
>
> + fsl-dpaa2-console@0x08340020 {
The node name should be generic, 'console' maybe? Also, the
unit-address shouldn't have 0x and leading zeros.
Shawn
> + compatible = "fsl,dpaa2-console";
> + reg = <0x00000000 0x08340020 0 0x2>;
> + };
> +
> fsl_mc: fsl-mc@80c000000 {
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index 6d6ca166f86b..f1521e6d8da0 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -321,6 +321,11 @@
> };
> };
>
> + fsl-dpaa2-console@0x08340020 {
> + compatible = "fsl,dpaa2-console";
> + reg = <0x00000000 0x08340020 0 0x2>;
> + };
> +
> fsl_mc: fsl-mc@80c000000 {
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 660e78e46268..8febaa517913 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -777,6 +777,11 @@
> dma-coherent;
> };
>
> + fsl-dpaa2-console@0x08340020 {
> + compatible = "fsl,dpaa2-console";
> + reg = <0x00000000 0x08340020 0 0x2>;
> + };
> +
> fsl_mc: fsl-mc@80c000000 {
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>,
> --
> 1.9.1
>
next prev parent reply other threads:[~2019-04-11 2:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 19:23 [PATCH 0/2] arm64: dts: add fsl-dpaa2-console node Ioana Ciornei
2019-03-26 19:23 ` [PATCH 1/2] arm64: dts: add fsl-dpaa2-console node for DPAA2 platforms Ioana Ciornei
2019-04-11 2:05 ` Shawn Guo [this message]
2019-03-26 19:23 ` [PATCH 2/2] Documentation: DT: Add entry for DPAA2 console Ioana Ciornei
2019-04-03 9:23 ` Shawn Guo
2019-04-03 9:31 ` Shawn Guo
2019-04-03 16:59 ` Li Yang
[not found] ` <5ca0614d.1c69fb81.acc38.6e23@mx.google.com>
2019-04-08 20:21 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411020528.GH26817@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=leoyang.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.