From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 2/2] spi: pxa2xx: use a module softdep for dw_dmac Date: Thu, 11 Apr 2019 11:42:12 +0100 Message-ID: <20190411104212.GA7953@sirena.org.uk> References: <1554900696-28858-1-git-send-email-f.suligoi@asem.it> <1554900696-28858-2-git-send-email-f.suligoi@asem.it> <20190410125612.GR6106@sirena.org.uk> <6eeaf42f4d3f42c58546c429194213b8@asem.it> <20190410152820.GT6106@sirena.org.uk> <7ad025c8049e4e828ce75ef1e41dcbfd@asem.it> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , "linux-arm-kernel@lists.infradead.org" , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Flavio Suligoi Return-path: Content-Disposition: inline In-Reply-To: <7ad025c8049e4e828ce75ef1e41dcbfd@asem.it> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 11, 2019 at 07:14:06AM +0000, Flavio Suligoi wrote: > > Right, yes - that analysis seems correct. The interfaces seem a bit > > weird here but fixing them looks like the most complete and robust fix. > Ok Mark, I'll fix this problem as soon as I can, using EPROBE_DEFER. > For now, in my application, I use the patch that I already sent, > with the "softdep" workaround: > MODULE_SOFTDEP("pre: dw_dmac"); > I tested it a lot, with more than 2000 cold reboot (automatic > switch on/off using a controlled power supply) and it always worked good. Right, and to be clear that patch is good and useful independently of the deferred probe fix so assuming nothing else comes up in review I'll apply it. --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlyvGgIACgkQJNaLcl1U h9A0zwf6AirGRh8bQQli94rYunYRwRhABvSKVNVzjNeqW24AoyboZcJZQcx/mc54 H/sAv4CsbVbYE+zrc1HtH/tV4fDucGRAuBGMAnUDOCCqbPYJWfLr+JfT3bqIiqX2 xY7sw7D9zv9HeSh2zOZzSFniLz59BiJ/iPf+FQC86UGwOZGD7ObiGcUbhQHuqYXT 4DYwgPTMpp4lFCZXnSXXJarOhgbXAW1qgAIRBNHkeRcns49p5K9otzxQX/S5BJ/i 8Wc5VqAHlqpDAeRN0slBFk5b46GrfCM0vvBiumcl0IZhxESXSN5lneqpIohPF0nq r1/WWyaRdIE36xqIMv02mAgujBqkmQ== =2+YG -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75D3C10F13 for ; Thu, 11 Apr 2019 10:42:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A91012184E for ; Thu, 11 Apr 2019 10:42:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B/KoKVbf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="fkNL7Gdv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A91012184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s9Pj1hpkhri34AV+2xOqx/vIiuYdi1Vx/E/AqTTA1Y4=; b=B/KoKVbf7XdZcBEPgTTQjKoqz DC3GbgmiEiAcE6wZYX/ql3TWaK68B2ZI0Szr65XZ6YJSuyPpmlWteYgmrucSH+I1MkPF4VccUmmXv TFEZa8NMxViMDWOoS8SSHzOkUNP+rRyfw4xvVQYl6XKihb7z2i16LMc9s7lIL9QP6JWHk0RcraABz y31KKpFE8jha5YmpedIbLyKekg2Xg++rCL4C2cbCu1YYCTGJlnwz1+5/myrTB88YzF68NoqU9KRF3 wntU27IzsfaN7oMSn5giLTqoLYdALNJeBmAc/KxKYzRJVGTQ9Rj8HxHKxbOmkdI/NaQMUuuSRJHji EsXoqGlag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEXA5-0002rx-1P; Thu, 11 Apr 2019 10:42:29 +0000 Received: from heliosphere.sirena.org.uk ([2a01:7e01::f03c:91ff:fed4:a3b6]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEXA2-0002rV-AM for linux-arm-kernel@lists.infradead.org; Thu, 11 Apr 2019 10:42:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RxYTHYqAnDKdcAy1D9zNoaWmD5GLxh6inlwtWWJPs3k=; b=fkNL7GdvG58XmAo/TRVAIrexb YfvVr0MG3ffa0T+DSrYeDblB2z8bysJtNhWMagrch3Y2E8mXaghZsMfq7EPq87XuMta1q6XSQjpoA ajJ1qCK895xhAGRUOG8S2sfrULzp0UL1BUJDW+HrmGGkS+KPC5an/kdydPHOWZzMb0/Vg=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hEX9u-0008Nr-Re; Thu, 11 Apr 2019 10:42:18 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id D8FF51126DD0; Thu, 11 Apr 2019 11:42:12 +0100 (BST) Date: Thu, 11 Apr 2019 11:42:12 +0100 From: Mark Brown To: Flavio Suligoi Subject: Re: [PATCH 2/2] spi: pxa2xx: use a module softdep for dw_dmac Message-ID: <20190411104212.GA7953@sirena.org.uk> References: <1554900696-28858-1-git-send-email-f.suligoi@asem.it> <1554900696-28858-2-git-send-email-f.suligoi@asem.it> <20190410125612.GR6106@sirena.org.uk> <6eeaf42f4d3f42c58546c429194213b8@asem.it> <20190410152820.GT6106@sirena.org.uk> <7ad025c8049e4e828ce75ef1e41dcbfd@asem.it> MIME-Version: 1.0 In-Reply-To: <7ad025c8049e4e828ce75ef1e41dcbfd@asem.it> X-Cookie: Save the bales! User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_034226_514986_A0165A01 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Haojian Zhuang , "linux-spi@vger.kernel.org" , Daniel Mack , Robert Jarzmik , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============1536250258424112402==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1536250258424112402== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 11, 2019 at 07:14:06AM +0000, Flavio Suligoi wrote: > > Right, yes - that analysis seems correct. The interfaces seem a bit > > weird here but fixing them looks like the most complete and robust fix. > Ok Mark, I'll fix this problem as soon as I can, using EPROBE_DEFER. > For now, in my application, I use the patch that I already sent, > with the "softdep" workaround: > MODULE_SOFTDEP("pre: dw_dmac"); > I tested it a lot, with more than 2000 cold reboot (automatic > switch on/off using a controlled power supply) and it always worked good. Right, and to be clear that patch is good and useful independently of the deferred probe fix so assuming nothing else comes up in review I'll apply it. --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlyvGgIACgkQJNaLcl1U h9A0zwf6AirGRh8bQQli94rYunYRwRhABvSKVNVzjNeqW24AoyboZcJZQcx/mc54 H/sAv4CsbVbYE+zrc1HtH/tV4fDucGRAuBGMAnUDOCCqbPYJWfLr+JfT3bqIiqX2 xY7sw7D9zv9HeSh2zOZzSFniLz59BiJ/iPf+FQC86UGwOZGD7ObiGcUbhQHuqYXT 4DYwgPTMpp4lFCZXnSXXJarOhgbXAW1qgAIRBNHkeRcns49p5K9otzxQX/S5BJ/i 8Wc5VqAHlqpDAeRN0slBFk5b46GrfCM0vvBiumcl0IZhxESXSN5lneqpIohPF0nq r1/WWyaRdIE36xqIMv02mAgujBqkmQ== =2+YG -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL-- --===============1536250258424112402== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1536250258424112402==--