From: Bjorn Helgaas <helgaas@kernel.org>
To: Nikolai Kostrigin <nickel@altlinux.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>,
Alexander Deucher <Alexander.Deucher@amd.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Christian Koenig <Christian.Koenig@amd.com>
Subject: Re: [PATCH RESEND 1/1] PCI: Add ATS-disable quirk for AMD Radeon R7 GPUs
Date: Thu, 11 Apr 2019 08:59:03 -0500 [thread overview]
Message-ID: <20190411135903.GP256045@google.com> (raw)
In-Reply-To: <20190408103725.30426-2-nickel@altlinux.org>
[+cc Alex, Suravee, Thomas, Felix, Christian]
On Mon, Apr 08, 2019 at 01:37:25PM +0300, Nikolai Kostrigin wrote:
> ATS is broken on this hardware (at least for Stoney Ridge
> based laptop) and causes IOMMU stalls and
> system failure. Disable ATS on these devices to make them
> usable again with IOMMU enabled
> Thanks to Joerg Roedel <jroedel@suse.de> for help.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=194521
>
> Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>
I applied this to pci/virtualization for v5.2 with Joerg's ack, a stable
tag, and a note about Alex's suspicion that this may be system-specific and
may also affect other devices.
> ---
> drivers/pci/quirks.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 4700d24e5d55..abb2532e16bf 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4876,6 +4876,7 @@ static void quirk_no_ats(struct pci_dev *pdev)
>
> /* AMD Stoney platform GPU */
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x98e4, quirk_no_ats);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x6900, quirk_no_ats);
> #endif /* CONFIG_PCI_ATS */
>
> /* Freescale PCIe doesn't support MSI in RC mode */
> --
> 2.21.0
>
prev parent reply other threads:[~2019-04-11 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 10:37 [PATCH RESEND 0/1] PCI: Add ATS-disable quirk for AMD Radeon R7 GPUs Nikolai Kostrigin
2019-04-08 10:37 ` [PATCH RESEND 1/1] " Nikolai Kostrigin
2019-04-09 21:59 ` Bjorn Helgaas
[not found] ` <8b4659c8-3f49-de62-a616-a35a1d0c68b9@basealt.ru>
2019-04-10 8:03 ` Nikolai Kostrigin
2019-04-10 21:26 ` Bjorn Helgaas
2019-04-10 14:46 ` Deucher, Alexander
2019-04-10 15:59 ` Deucher, Alexander
2019-04-11 12:36 ` jroedel
2019-04-11 12:38 ` Joerg Roedel
2019-04-11 13:59 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411135903.GP256045@google.com \
--to=helgaas@kernel.org \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nickel@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.