From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/amd: remove the leftover of bypass support Date: Thu, 11 Apr 2019 17:38:09 +0200 Message-ID: <20190411153809.GG4518@8bytes.org> References: <20190410165014.9932-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190410165014.9932-1-hch-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Apr 10, 2019 at 06:50:14PM +0200, Christoph Hellwig wrote: > The AMD iommu dma_ops are only attached on a per-device basis when an > actual translation is needed. Remove the leftover bypass support which > in parts was already broken (e.g. it always returns 0 from ->map_sg). > > Use the opportunity to remove a few local variables and move assignments > into the declaration line where they were previously separated by the > bypass check. > > Signed-off-by: Christoph Hellwig > --- > drivers/iommu/amd_iommu.c | 80 +++++++++------------------------------ > 1 file changed, 17 insertions(+), 63 deletions(-) Nice cleanup, applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AABBC10F14 for ; Thu, 11 Apr 2019 15:39:07 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 336452083E for ; Thu, 11 Apr 2019 15:39:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 336452083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id CF45228DD; Thu, 11 Apr 2019 15:39:06 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 22EE729A7 for ; Thu, 11 Apr 2019 15:38:14 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id BCA5063D for ; Thu, 11 Apr 2019 15:38:13 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 55FED451; Thu, 11 Apr 2019 17:38:11 +0200 (CEST) Date: Thu, 11 Apr 2019 17:38:09 +0200 From: Joerg Roedel To: Christoph Hellwig Subject: Re: [PATCH] iommu/amd: remove the leftover of bypass support Message-ID: <20190411153809.GG4518@8bytes.org> References: <20190410165014.9932-1-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190410165014.9932-1-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190411153809.gsBH0ZdznVxOphxzh-bGJNXdFe0CfGLi0ojqz0AjRSw@z> On Wed, Apr 10, 2019 at 06:50:14PM +0200, Christoph Hellwig wrote: > The AMD iommu dma_ops are only attached on a per-device basis when an > actual translation is needed. Remove the leftover bypass support which > in parts was already broken (e.g. it always returns 0 from ->map_sg). > > Use the opportunity to remove a few local variables and move assignments > into the declaration line where they were previously separated by the > bypass check. > > Signed-off-by: Christoph Hellwig > --- > drivers/iommu/amd_iommu.c | 80 +++++++++------------------------------ > 1 file changed, 17 insertions(+), 63 deletions(-) Nice cleanup, applied, thanks! _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu