From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace definition ANDROID with __ANDROID__
Date: Thu, 11 Apr 2019 19:46:38 +0200 [thread overview]
Message-ID: <20190411174638.GA11576@dell5510> (raw)
In-Reply-To: <1554992779-14595-1-git-send-email-ruanzw@xiaopeng.com>
Hi,
> Replace the incorrect definition of ANDROID with __ANDROID__.
> +++ b/testcases/kernel/syscalls/rt_tgsigqueueinfo/rt_tgsigqueueinfo01.c
> @@ -25,7 +25,7 @@
> #include "tst_test.h"
> #include "lapi/syscalls.h"
> -#ifndef ANDROID
> +#ifndef __ANDROID__
Simple grep in AOSP tree would be for this change (and I'd personally prefer it as well)
I'd kindly ask android devs which one is correct :). BTW ANDROID was added by Steve.
$ cgrep '#if.* __ANDROID__' |wc -l
405
$ cgrep '#if.* ANDROID[^_]' |wc -l
22
Kind regards,
Petr
next prev parent reply other threads:[~2019-04-11 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 14:26 [LTP] [PATCH v1] rt_tgsigqueueinfo01.c: replace definition ANDROID with __ANDROID__ Zhengwang Ruan
2019-04-11 17:46 ` Petr Vorel [this message]
2019-04-12 15:36 ` =?unknown-8bit?b?6Ziu5q2j5pe6?=
2019-04-12 19:49 ` Sandeep Patil
2019-04-14 10:11 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411174638.GA11576@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.