From: Josh Triplett <josh@joshtriplett.org>
To: Sinan Kaya <Okaya@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Nicholas Piggin <npiggin@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Vasily Gorbik <gor@linux.ibm.com>, Adrian Reber <adrian@lisas.de>,
Richard Guy Briggs <rgb@redhat.com>,
Petr Mladek <pmladek@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Robin Murphy <robin.murphy@arm.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Changbin Du <changbin.du@intel.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default
Date: Thu, 11 Apr 2019 15:16:45 -0700 [thread overview]
Message-ID: <20190411221645.GA8692@localhost> (raw)
In-Reply-To: <e901a9cc-f335-fb31-535c-97dce2ca8f5b@kernel.org>
On Wed, Apr 10, 2019 at 11:13:52PM -0400, Sinan Kaya wrote:
> On 4/10/2019 11:02 PM, Josh Triplett wrote:
> > Then let's fix*that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this.
>
> I think we have to do both. We need to go after the users as well as
> solve the immediate problem per this patch.
>
> As Mathieu identified, CONFIG_DEBUG_KERNEL is being used all over the
> place and getting subsystem owners to remove let alone add a check
> to checkpatch is just going to take time.
>
> Please let us know if you are OK with this plan.
I'm not OK with this plan. Turning on EXPERT should make the options
under DEBUG_KERNEL visible; it's a bug that DEBUG_KERNEL affects code
generation as well.
Proposed alternative plan: let's add a new symbol, something like
DEBUG_MISC ("Miscellaneous debug code that should be under a more
specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
"default DEBUG_KERNEL" but allow itself to be turned off, and then
mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
"#ifdef CONFIG_DEBUG_MISC".
Does that sound like an appropriately rapid solution for this bug?
next prev parent reply other threads:[~2019-04-11 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 22:42 [PATCH v2] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-10 22:58 ` Kees Cook
2019-04-10 23:22 ` Josh Triplett
2019-04-10 23:24 ` Kees Cook
2019-04-11 3:02 ` Josh Triplett
2019-04-11 3:13 ` Sinan Kaya
2019-04-11 22:16 ` Josh Triplett [this message]
2019-04-11 22:21 ` Kees Cook
2019-04-11 22:27 ` Sinan Kaya
2019-04-11 22:34 ` Josh Triplett
2019-04-11 3:44 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411221645.GA8692@localhost \
--to=josh@joshtriplett.org \
--cc=Okaya@kernel.org \
--cc=adrian@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changbin.du@intel.com \
--cc=fweisbec@gmail.com \
--cc=gor@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=joe.lawrence@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=mpatocka@redhat.com \
--cc=npiggin@gmail.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rgb@redhat.com \
--cc=robin.murphy@arm.com \
--cc=sam@ravnborg.org \
--cc=willy@infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.