All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: Sinan Kaya <okaya@kernel.org>
Cc: linux-kernel@vger.kernel.org, keescook@chromium.org
Subject: Re: [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default
Date: Thu, 11 Apr 2019 20:02:38 -0700	[thread overview]
Message-ID: <20190412030237.GB1577@localhost> (raw)
In-Reply-To: <20190412014355.25307-1-okaya@kernel.org>

On Fri, Apr 12, 2019 at 01:43:50AM +0000, Sinan Kaya wrote:
> CONFIG_DEBUG_KERNEL has been designed to just enable Kconfig options.
> Kernel code generatoin should not depend on CONFIG_DEBUG_KERNEL.
> 
> Proposed alternative plan: let's add a new symbol, something like
> DEBUG_MISC ("Miscellaneous debug code that should be under a more
> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
> "default DEBUG_KERNEL" but allow itself to be turned off, and then
> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
> "#ifdef CONFIG_DEBUG_MISC".
> 
> Sinan Kaya (5):
>   init: Introduce DEBUG_MISC option
>   powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>   mips: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>   xtensa: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>   net: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC

I noticed one minor typo in patch 1/5, with that fixed, for the whole
series:

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

  parent reply	other threads:[~2019-04-12  3:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  1:43 [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 1/5] init: Introduce DEBUG_MISC option Sinan Kaya
2019-04-12  3:01   ` Josh Triplett
2019-04-12  1:43 ` [PATCH v4 2/5] powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC Sinan Kaya
2019-04-12  1:43   ` Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 3/5] mips: " Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 4/5] xtensa: " Sinan Kaya
2019-04-12  1:43 ` [PATCH v4 5/5] net: " Sinan Kaya
2019-04-12  8:09   ` Florian Westphal
2019-04-12  3:02 ` Josh Triplett [this message]
2019-04-12  3:13   ` [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-12  4:05     ` Josh Triplett
2019-04-12  4:06       ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412030237.GB1577@localhost \
    --to=josh@joshtriplett.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okaya@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.