From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:44897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hErWQ-0005gF-5b for qemu-devel@nongnu.org; Fri, 12 Apr 2019 04:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hErWP-0005RG-0a for qemu-devel@nongnu.org; Fri, 12 Apr 2019 04:26:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33524) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hErWO-0005Qp-Lm for qemu-devel@nongnu.org; Fri, 12 Apr 2019 04:26:52 -0400 Date: Fri, 12 Apr 2019 10:26:47 +0200 From: Erik Skultety Message-ID: <20190412082647.GD16137@beluga.usersys.redhat.com> References: <20190411235456.12918-1-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190411235456.12918-1-brijesh.singh@amd.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Singh, Brijesh" Cc: "qemu-devel@nongnu.org" , Paolo Bonzini , Markus Armbruster , Eric Blake , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Laszlo Ersek , "Lendacky, Thomas" On Thu, Apr 11, 2019 at 11:55:15PM +0000, Singh, Brijesh wrote: > There are limited numbers of the SEV guests that can be run concurrentl= y. > A management applications may need to know this limit so that it can pl= ace > SEV VMs on hosts which have suitable resources available. > > Currently, this limit is not exposed to the application. Add a new > 'sev-max-guest' field in the query-sev-capabilities to provide this > information. > > Cc: Paolo Bonzini > Cc: Markus Armbruster > Cc: Eric Blake > Cc: Daniel P. Berrang=C3=A9 > Cc: Laszlo Ersek > Cc: Erik Skultety > Cc: Tom Lendacky > Signed-off-by: Brijesh Singh > --- > > changes since v1: > - document the new field and add (since 4.1) annotation. > > qapi/target.json | 9 +++++++-- > target/i386/sev.c | 9 +++++++-- > 2 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/qapi/target.json b/qapi/target.json > index 1d4d54b600..8cd4fc7919 100644 > --- a/qapi/target.json > +++ b/qapi/target.json > @@ -177,13 +177,17 @@ > # @reduced-phys-bits: Number of physical Address bit reduction when SE= V is > # enabled > # > +# @sev-max-guests: maximum number of concurrent SEV guest with SEV-ES = disabled > +# (since 4.1) > +# > # Since: 2.12 > ## > { 'struct': 'SevCapability', > 'data': { 'pdh': 'str', > 'cert-chain': 'str', > 'cbitpos': 'int', > - 'reduced-phys-bits': 'int'}, > + 'reduced-phys-bits': 'int', > + 'sev-max-guests': 'int'}, > 'if': 'defined(TARGET_I386)' } > > ## > @@ -200,7 +204,8 @@ > # > # -> { "execute": "query-sev-capabilities" } > # <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE", > -# "cbitpos": 47, "reduced-phys-bits": 5}} > +# "cbitpos": 47, "reduced-phys-bits": 5, > +# "sev-max-guests" : 15}} > # > ## > { 'command': 'query-sev-capabilities', 'returns': 'SevCapability', > diff --git a/target/i386/sev.c b/target/i386/sev.c > index cd77f6b5d4..6829586fbe 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -488,7 +488,7 @@ sev_get_capabilities(void) > guchar *pdh_data =3D NULL; > guchar *cert_chain_data =3D NULL; > size_t pdh_len =3D 0, cert_chain_len =3D 0; > - uint32_t ebx; > + uint32_t ebx, ecx, edx; > int fd; > > fd =3D open(DEFAULT_SEV_DEVICE, O_RDWR); > @@ -507,7 +507,7 @@ sev_get_capabilities(void) > cap->pdh =3D g_base64_encode(pdh_data, pdh_len); > cap->cert_chain =3D g_base64_encode(cert_chain_data, cert_chain_le= n); > > - host_cpuid(0x8000001F, 0, NULL, &ebx, NULL, NULL); > + host_cpuid(0x8000001F, 0, NULL, &ebx, &ecx, &edx); > cap->cbitpos =3D ebx & 0x3f; > > /* > @@ -516,6 +516,11 @@ sev_get_capabilities(void) > */ > cap->reduced_phys_bits =3D 1; > > + /* > + * The maximum number of SEV guests with SEV-ES disabled that can = run > + * simultaneously. > + */ > + cap->sev_max_guests =3D ecx - edx + 1; I'm not that familiar with QEMU code, so I guess ^this works as intended,= but to the idea (and per my comment in v1): Reviewed-by: Erik Skultety From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48DADC10F14 for ; Fri, 12 Apr 2019 08:28:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E1452075B for ; Fri, 12 Apr 2019 08:28:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E1452075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:60783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hErXb-0006OU-7H for qemu-devel@archiver.kernel.org; Fri, 12 Apr 2019 04:28:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hErWQ-0005gF-5b for qemu-devel@nongnu.org; Fri, 12 Apr 2019 04:26:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hErWP-0005RG-0a for qemu-devel@nongnu.org; Fri, 12 Apr 2019 04:26:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33524) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hErWO-0005Qp-Lm for qemu-devel@nongnu.org; Fri, 12 Apr 2019 04:26:52 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E00BF88317; Fri, 12 Apr 2019 08:26:51 +0000 (UTC) Received: from beluga.usersys.redhat.com (unknown [10.43.2.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB53A60FCD; Fri, 12 Apr 2019 08:26:49 +0000 (UTC) Date: Fri, 12 Apr 2019 10:26:47 +0200 From: Erik Skultety To: "Singh, Brijesh" Message-ID: <20190412082647.GD16137@beluga.usersys.redhat.com> References: <20190411235456.12918-1-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190411235456.12918-1-brijesh.singh@amd.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 12 Apr 2019 08:26:51 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2] target/i386: sev: add 'sev-max-guests' field to 'query-sev-capabilities' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lendacky, Thomas" , Laszlo Ersek , "qemu-devel@nongnu.org" , Markus Armbruster , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190412082647.fnKL9imgWR4G2dPuEbrWOasp9Ki-AcB9JgcBTnnbV1g@z> On Thu, Apr 11, 2019 at 11:55:15PM +0000, Singh, Brijesh wrote: > There are limited numbers of the SEV guests that can be run concurrentl= y. > A management applications may need to know this limit so that it can pl= ace > SEV VMs on hosts which have suitable resources available. > > Currently, this limit is not exposed to the application. Add a new > 'sev-max-guest' field in the query-sev-capabilities to provide this > information. > > Cc: Paolo Bonzini > Cc: Markus Armbruster > Cc: Eric Blake > Cc: Daniel P. Berrang=C3=A9 > Cc: Laszlo Ersek > Cc: Erik Skultety > Cc: Tom Lendacky > Signed-off-by: Brijesh Singh > --- > > changes since v1: > - document the new field and add (since 4.1) annotation. > > qapi/target.json | 9 +++++++-- > target/i386/sev.c | 9 +++++++-- > 2 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/qapi/target.json b/qapi/target.json > index 1d4d54b600..8cd4fc7919 100644 > --- a/qapi/target.json > +++ b/qapi/target.json > @@ -177,13 +177,17 @@ > # @reduced-phys-bits: Number of physical Address bit reduction when SE= V is > # enabled > # > +# @sev-max-guests: maximum number of concurrent SEV guest with SEV-ES = disabled > +# (since 4.1) > +# > # Since: 2.12 > ## > { 'struct': 'SevCapability', > 'data': { 'pdh': 'str', > 'cert-chain': 'str', > 'cbitpos': 'int', > - 'reduced-phys-bits': 'int'}, > + 'reduced-phys-bits': 'int', > + 'sev-max-guests': 'int'}, > 'if': 'defined(TARGET_I386)' } > > ## > @@ -200,7 +204,8 @@ > # > # -> { "execute": "query-sev-capabilities" } > # <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE", > -# "cbitpos": 47, "reduced-phys-bits": 5}} > +# "cbitpos": 47, "reduced-phys-bits": 5, > +# "sev-max-guests" : 15}} > # > ## > { 'command': 'query-sev-capabilities', 'returns': 'SevCapability', > diff --git a/target/i386/sev.c b/target/i386/sev.c > index cd77f6b5d4..6829586fbe 100644 > --- a/target/i386/sev.c > +++ b/target/i386/sev.c > @@ -488,7 +488,7 @@ sev_get_capabilities(void) > guchar *pdh_data =3D NULL; > guchar *cert_chain_data =3D NULL; > size_t pdh_len =3D 0, cert_chain_len =3D 0; > - uint32_t ebx; > + uint32_t ebx, ecx, edx; > int fd; > > fd =3D open(DEFAULT_SEV_DEVICE, O_RDWR); > @@ -507,7 +507,7 @@ sev_get_capabilities(void) > cap->pdh =3D g_base64_encode(pdh_data, pdh_len); > cap->cert_chain =3D g_base64_encode(cert_chain_data, cert_chain_le= n); > > - host_cpuid(0x8000001F, 0, NULL, &ebx, NULL, NULL); > + host_cpuid(0x8000001F, 0, NULL, &ebx, &ecx, &edx); > cap->cbitpos =3D ebx & 0x3f; > > /* > @@ -516,6 +516,11 @@ sev_get_capabilities(void) > */ > cap->reduced_phys_bits =3D 1; > > + /* > + * The maximum number of SEV guests with SEV-ES disabled that can = run > + * simultaneously. > + */ > + cap->sev_max_guests =3D ecx - edx + 1; I'm not that familiar with QEMU code, so I guess ^this works as intended,= but to the idea (and per my comment in v1): Reviewed-by: Erik Skultety