From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Cc: Joshua Kinard <kumba@gentoo.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] rtc: ds1685: fix crash caused by referencing wrong device struct
Date: Fri, 12 Apr 2019 12:14:56 +0200 [thread overview]
Message-ID: <20190412101456.GW3578@piout.net> (raw)
In-Reply-To: <20190411143323.20945-1-tbogendoerfer@suse.de>
On 11/04/2019 16:33:21+0200, Thomas Bogendoerfer wrote:
> sysfs entries added by rtc_add_group are called with the rtc device
> as argument and not the underlying device. Fixed by using the dev->parent
>
> Fixes: cfb74916e2ec ("rtc: ds1685: use rtc_add_group")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
> drivers/rtc/rtc-ds1685.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-04-12 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 14:33 [PATCH 1/3] rtc: ds1685: fix crash caused by referencing wrong device struct Thomas Bogendoerfer
2019-04-11 14:33 ` [PATCH 2/3] rtc: ds1685: use correct device struct to get platform " Thomas Bogendoerfer
2019-04-12 10:11 ` Alexandre Belloni
2019-04-12 11:44 ` Thomas Bogendoerfer
2019-04-13 5:17 ` Joshua Kinard
2019-04-13 8:19 ` Thomas Bogendoerfer
2019-04-11 14:33 ` [PATCH 3/3] rtc: ds1685: disable interrupts when moving work to work queue Thomas Bogendoerfer
2019-04-12 10:14 ` Alexandre Belloni
2019-04-12 11:49 ` Thomas Bogendoerfer
2019-04-12 10:14 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412101456.GW3578@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.