All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: IGT dev <igt-dev@lists.freedesktop.org>, Andi Shyti <andi@etezian.org>
Subject: Re: [igt-dev] [PATCH v20 2/6] lib/i915: add gem_engine_topology library and for_each loop definition
Date: Fri, 12 Apr 2019 18:32:52 +0300	[thread overview]
Message-ID: <20190412153252.GB3111@intel.intel> (raw)
In-Reply-To: <155505699774.24519.13584751792529013522@skylake-alporthouse-com>

> > +int64_t gem_map_all_engines(int fd)
> 
> int64_t?

yeah... should be uint32_t, I forgot gem_context_create had some
igt_requires, I thought 32 bit for ctx_id and the rest for
-errno.

I don't even need 'gem_require_contexts()', because it
basically does the same thing of 'gem_context_create()'

> There's no indication this creates a context.
> 
> int gem_context_map_all_engines(int i915, uint32_t ctx)

I wanted the caller not to care about the context. I can probably
call it 'gem_create_populated_context()'?

> {
> 	/* ... */
> 	return param.num_engines;
> }
> 
> map? set, expose, populate

my bad naming skills :)

Thanks, Chris,
Andi

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-04-12 15:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  0:32 [igt-dev] [PATCH v20 0/6] new engine discovery interface Andi Shyti
2019-04-12  0:32 ` [igt-dev] [PATCH v20 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti
2019-04-12  0:32 ` [igt-dev] [PATCH v20 2/6] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti
2019-04-12  8:16   ` Chris Wilson
2019-04-12 15:32     ` Andi Shyti [this message]
2019-04-12 16:31       ` Chris Wilson
2019-04-12  0:32 ` [igt-dev] [PATCH v20 3/6] lib: igt_gt: add eb flags to class helper Andi Shyti
2019-04-12  8:18   ` Chris Wilson
2019-04-12  8:18   ` Chris Wilson
2019-04-12  0:32 ` [igt-dev] [PATCH v20 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti
2019-04-12  0:32 ` [igt-dev] [PATCH v20 5/6] lib: igt_dummyload: use for_each_context_engine() Andi Shyti
2019-04-12  0:32 ` [igt-dev] [PATCH v20 6/6] test: perf_pmu: use the gem_engine_topology library Andi Shyti
2019-04-12 11:34 ` [igt-dev] ✓ Fi.CI.BAT: success for new engine discovery interface Patchwork
2019-04-12 15:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190412153252.GB3111@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=andi@etezian.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.