From: Kalle Valo <kvalo@codeaurora.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
"Tomislav Požega" <pozega.tomislav@gmail.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Felix Fietkau" <nbd@nbd.name>, "Mathias Kresin" <dev@kresin.me>,
"Vijayakumar Durai" <vijayakumar.durai1@vivint.com>,
stable@vger.kernel.org, "Stanislaw Gruszka" <sgruszka@redhat.com>
Subject: Re: [PATCH 5.1] rt2x00: do not increment sequence number while re-transmitting
Date: Fri, 12 Apr 2019 18:31:58 +0000 (UTC) [thread overview]
Message-ID: <20190412183158.6D98C61788@smtp.codeaurora.org> (raw)
In-Reply-To: <1553680997-19511-1-git-send-email-sgruszka@redhat.com>
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> From: Vijayakumar Durai <vijayakumar.durai1@vivint.com>
>
> Currently rt2x00 devices retransmit the management frames with
> incremented sequence number if hardware is assigning the sequence.
>
> This is HW bug fixed already for non-QOS data frames, but it should
> be fixed for management frames except beacon.
>
> Without fix retransmitted frames have wrong SN:
>
> AlphaNet_e8:fb:36 Vivotek_52:31:51 Authentication, SN=1648, FN=0, Flags=........C Frame is not being retransmitted 1648 1
> AlphaNet_e8:fb:36 Vivotek_52:31:51 Authentication, SN=1649, FN=0, Flags=....R...C Frame is being retransmitted 1649 1
> AlphaNet_e8:fb:36 Vivotek_52:31:51 Authentication, SN=1650, FN=0, Flags=....R...C Frame is being retransmitted 1650 1
>
> With the fix SN stays correctly the same:
>
> 88:6a:e3:e8:f9:a2 8c:f5:a3:88:76:87 Authentication, SN=1450, FN=0, Flags=........C
> 88:6a:e3:e8:f9:a2 8c:f5:a3:88:76:87 Authentication, SN=1450, FN=0, Flags=....R...C
> 88:6a:e3:e8:f9:a2 8c:f5:a3:88:76:87 Authentication, SN=1450, FN=0, Flags=....R...C
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Vijayakumar Durai <vijayakumar.durai1@vivint.com>
> [sgruszka: simplify code, change comments and changelog]
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers.git, thanks.
746ba11f1706 rt2x00: do not increment sequence number while re-transmitting
--
https://patchwork.kernel.org/patch/10873171/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-04-12 18:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 10:03 [PATCH 5.1] rt2x00: do not increment sequence number while re-transmitting Stanislaw Gruszka
2019-03-29 14:16 ` Sasha Levin
2019-04-12 18:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412183158.6D98C61788@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
--cc=sgruszka@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vijayakumar.durai1@vivint.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.