From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH 1/4] dt-bindings: usb: dwc2: Document quirk to reset PHY upon wakeup Date: Fri, 12 Apr 2019 16:42:18 -0700 Message-ID: <20190412234218.GX112750@google.com> References: <20190412224149.106971-1-dianders@chromium.org> <20190412224149.106971-2-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190412224149.106971-2-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Anderson Cc: Rob Herring , Minas Harutyunyan , Heiko Stuebner , Felipe Balbi , amstan@chromium.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, Randy Li , ryandcase@chromium.org, jwerner@chromium.org, Elaine Zhang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Mark Rutland List-Id: linux-rockchip.vger.kernel.org On Fri, Apr 12, 2019 at 03:41:46PM -0700, Douglas Anderson wrote: > On Rockchip rk3288 there's a hardware quirk where we need to assert > the reset signal to the PHY when we get a remote wakeup on one of the > two ports. Document this quirk in the bindings. > > Signed-off-by: Douglas Anderson > --- > > Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt > index 6dc3c4a34483..f70f3aee4bfc 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.txt > +++ b/Documentation/devicetree/bindings/usb/dwc2.txt > @@ -37,6 +37,8 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties > - g-rx-fifo-size: size of rx fifo size in gadget mode. > - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. > - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode. > +- snps,reset-phy-on-wake: If present indicates that we need to reset the PHY when > + we detect a wakeup. This is due to a hardware errata. > > Deprecated properties: > - g-use-dma: gadget DMA mode is automatically detected Reviewed-by: Matthias Kaehlcke From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/4] dt-bindings: usb: dwc2: Document quirk to reset PHY upon wakeup From: Matthias Kaehlcke Message-Id: <20190412234218.GX112750@google.com> Date: Fri, 12 Apr 2019 16:42:18 -0700 To: Douglas Anderson Cc: Rob Herring , Minas Harutyunyan , Heiko Stuebner , Felipe Balbi , amstan@chromium.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, Randy Li , ryandcase@chromium.org, jwerner@chromium.org, Elaine Zhang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Mark Rutland List-ID: T24gRnJpLCBBcHIgMTIsIDIwMTkgYXQgMDM6NDE6NDZQTSAtMDcwMCwgRG91Z2xhcyBBbmRlcnNv biB3cm90ZToKPiBPbiBSb2NrY2hpcCByazMyODggdGhlcmUncyBhIGhhcmR3YXJlIHF1aXJrIHdo ZXJlIHdlIG5lZWQgdG8gYXNzZXJ0Cj4gdGhlIHJlc2V0IHNpZ25hbCB0byB0aGUgUEhZIHdoZW4g d2UgZ2V0IGEgcmVtb3RlIHdha2V1cCBvbiBvbmUgb2YgdGhlCj4gdHdvIHBvcnRzLiAgRG9jdW1l bnQgdGhpcyBxdWlyayBpbiB0aGUgYmluZGluZ3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogRG91Z2xh cyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgo+IC0tLQo+IAo+ICBEb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2R3YzIudHh0IHwgMiArKwo+ICAxIGZpbGUgY2hh bmdlZCwgMiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy91c2IvZHdjMi50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvdXNiL2R3YzIudHh0Cj4gaW5kZXggNmRjM2M0YTM0NDgzLi5mNzBmM2FlZTRiZmMg MTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9kd2My LnR4dAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZHdjMi50 eHQKPiBAQCAtMzcsNiArMzcsOCBAQCBSZWZlciB0byBwaHkvcGh5LWJpbmRpbmdzLnR4dCBmb3Ig Z2VuZXJpYyBwaHkgY29uc3VtZXIgcHJvcGVydGllcwo+ICAtIGctcngtZmlmby1zaXplOiBzaXpl IG9mIHJ4IGZpZm8gc2l6ZSBpbiBnYWRnZXQgbW9kZS4KPiAgLSBnLW5wLXR4LWZpZm8tc2l6ZTog c2l6ZSBvZiBub24tcGVyaW9kaWMgdHggZmlmbyBzaXplIGluIGdhZGdldCBtb2RlLgo+ICAtIGct dHgtZmlmby1zaXplOiBzaXplIG9mIHBlcmlvZGljIHR4IGZpZm8gcGVyIGVuZHBvaW50IChleGNl cHQgZXAwKSBpbiBnYWRnZXQgbW9kZS4KPiArLSBzbnBzLHJlc2V0LXBoeS1vbi13YWtlOiBJZiBw cmVzZW50IGluZGljYXRlcyB0aGF0IHdlIG5lZWQgdG8gcmVzZXQgdGhlIFBIWSB3aGVuCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgd2UgZGV0ZWN0IGEgd2FrZXVwLiAgVGhpcyBpcyBkdWUg dG8gYSBoYXJkd2FyZSBlcnJhdGEuCj4gIAo+ICBEZXByZWNhdGVkIHByb3BlcnRpZXM6Cj4gIC0g Zy11c2UtZG1hOiBnYWRnZXQgRE1BIG1vZGUgaXMgYXV0b21hdGljYWxseSBkZXRlY3RlZAoKUmV2 aWV3ZWQtYnk6IE1hdHRoaWFzIEthZWhsY2tlIDxta2FAY2hyb21pdW0ub3JnPgo=