From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4CAC10F11 for ; Sat, 13 Apr 2019 17:27:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04CC920850 for ; Sat, 13 Apr 2019 17:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727216AbfDMR1w (ORCPT ); Sat, 13 Apr 2019 13:27:52 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:35218 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbfDMR1w (ORCPT ); Sat, 13 Apr 2019 13:27:52 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hFMRS-0005dG-Gs; Sat, 13 Apr 2019 17:27:50 +0000 Date: Sat, 13 Apr 2019 18:27:50 +0100 From: Al Viro To: Jens Axboe Cc: linux-fsdevel@vger.kernel.org Subject: dead code in io_file_put() Message-ID: <20190413172750.GN2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org It's never called with NULL first argument anymore. Is there any reason to keep that check (and the second argument, never used when state != NULL) there? Frankly, I wonder if there is any point in that fget_many()/fput_many() stuff. Does the benefit from that really show up in any profiles?