From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 3/3] phy: warn if phylib and ethtool PHY mode definitions are out of sync
Date: Sat, 13 Apr 2019 22:18:29 +0200 [thread overview]
Message-ID: <20190413201829.GC28091@lunn.ch> (raw)
In-Reply-To: <35d549cb-7c40-b942-b002-305710fde6f0@gmail.com>
On Sat, Apr 13, 2019 at 08:53:43PM +0200, Heiner Kallweit wrote:
> If new PHY modes are added people may miss to update all relevant places
> in the kernel. Therefore add a build bug check for new modes in enum
> ethtool_link_mode_bit_indices that haven't been added to phylib yet.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-04-13 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 18:47 [PATCH v2 net-next 0/3] net: phy: shrink PHY settings array and add 200Gbps support Heiner Kallweit
2019-04-13 18:48 ` [PATCH v2 net-next 1/3] net: phy: shrink PHY settings array Heiner Kallweit
2019-04-13 20:17 ` Andrew Lunn
2019-04-13 18:50 ` [PATCH v2 net-next 2/3] net: phy: add support for new modes in phylib Heiner Kallweit
2019-04-13 20:17 ` Andrew Lunn
2019-04-13 18:53 ` [PATCH v2 net-next 3/3] phy: warn if phylib and ethtool PHY mode definitions are out of sync Heiner Kallweit
2019-04-13 20:18 ` Andrew Lunn [this message]
2019-04-14 20:37 ` [PATCH v2 net-next 0/3] net: phy: shrink PHY settings array and add 200Gbps support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190413201829.GC28091@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.