From: Benjamin Poirier <bpoirier@suse.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Quentin Monnet <quentin.monnet@netronome.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 bpf-next 1/2] bpftool: Use print_entry_error() in case of ENOENT when dumping
Date: Mon, 15 Apr 2019 08:29:35 +0900 [thread overview]
Message-ID: <20190414232935.GA8390@f1> (raw)
In-Reply-To: <20190412165301.1c4b7390@cakuba.netronome.com>
On 2019/04/12 16:53, Jakub Kicinski wrote:
> On Sat, 13 Apr 2019 07:49:24 +0900, Benjamin Poirier wrote:
> > To be honest, I don't think the formatting in those print_entry_*
> > functions should change according to the length in any case. I think the
> > key and value for each entry should always be on the same line for ease
> > of grepping. A followup patch maybe...
>
> No, no, please never grep bpftool output. We have JSON output,
> please use JQ: http://manpages.ubuntu.com/manpages/bionic/man1/jq.1.html
>
Fair enough. I didn't know about jq, thanks.
next prev parent reply other threads:[~2019-04-14 23:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 8:27 [PATCH bpf-next] bpftool: Exit early when it's not possible to dump a REUSEPORT_SOCKARRAY map Benjamin Poirier
2019-04-11 11:20 ` Quentin Monnet
2019-04-11 20:31 ` Jakub Kicinski
2019-04-12 3:03 ` [PATCH v2 bpf-next 1/2] bpftool: Use print_entry_error() in case of ENOENT when dumping Benjamin Poirier
2019-04-12 3:03 ` [PATCH v2 bpf-next 2/2] bpftool: Improve handling of ENOSPC on reuseport_array map dumps Benjamin Poirier
2019-04-12 10:28 ` Quentin Monnet
2019-04-13 0:00 ` Jakub Kicinski
2019-04-12 10:28 ` [PATCH v2 bpf-next 1/2] bpftool: Use print_entry_error() in case of ENOENT when dumping Quentin Monnet
2019-04-12 22:49 ` Benjamin Poirier
2019-04-12 23:53 ` Jakub Kicinski
2019-04-14 23:29 ` Benjamin Poirier [this message]
2019-04-12 23:57 ` Jakub Kicinski
2019-04-15 7:15 ` [PATCH v3 " Benjamin Poirier
2019-04-15 7:15 ` [PATCH v3 bpf-next 2/2] bpftool: Improve handling of ENOSPC on reuseport_array map dumps Benjamin Poirier
2019-04-15 9:20 ` Quentin Monnet
2019-04-15 18:38 ` Jakub Kicinski
2019-04-15 9:18 ` [PATCH v3 bpf-next 1/2] bpftool: Use print_entry_error() in case of ENOENT when dumping Quentin Monnet
2019-04-15 18:38 ` Jakub Kicinski
2019-04-16 8:29 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190414232935.GA8390@f1 \
--to=bpoirier@suse.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.