From: Sam Ravnborg <sam@ravnborg.org>
To: Inki Dae <inki.dae@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case
Date: Mon, 15 Apr 2019 05:17:39 +0200 [thread overview]
Message-ID: <20190415031739.GA9897@ravnborg.org> (raw)
In-Reply-To: <1555289240-7735-2-git-send-email-inki.dae@samsung.com>
Hi Inki
On Mon, Apr 15, 2019 at 09:47:19AM +0900, Inki Dae wrote:
> This patch makes error messages to be printed out using DRM_ERROR
> instead of DRM_INFO.
>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 786a8ee..78427ec 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -400,7 +400,7 @@ static int fimd_atomic_check(struct exynos_drm_crtc *crtc,
> u32 clkdiv;
>
> if (mode->clock == 0) {
> - DRM_INFO("Mode has zero clock value.\n");
> + DRM_ERROR("Mode has zero clock value.\n");
To give the logs a more precise info on where is comes from you
could consider to use:
DRM_DEV_ERROR(ctx->dev, "Mode has zero clock value.\n");
Likewise below.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-15 3:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190415004657epcas1p1e17d8c29c3488b8c86cac7d22cdc715b@epcas1p1.samsung.com>
2019-04-15 0:47 ` [PATCH 0/2] drm/exynos: clean up logs Inki Dae
2019-04-15 0:47 ` [PATCH 1/2] drm/fimd: use DRM_ERROR instead of DRM_INFO in error case Inki Dae
2019-04-15 3:17 ` Sam Ravnborg [this message]
2019-04-15 4:05 ` Inki Dae
2019-04-15 12:32 ` Ville Syrjälä
2019-04-15 0:47 ` [PATCH 2/2] drm/exynos: remove unnecessary messages Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415031739.GA9897@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.