From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] target:separate tx/rx cmd_puds
Date: Mon, 15 Apr 2019 10:51:38 +0000 [thread overview]
Message-ID: <20190415125138.2f0d09b7@suse.de> (raw)
In-Reply-To: <1521625963-657195-1-git-send-email-zhangzhuoyu@cmss.chinamobile.com>
[replying to an old thread]
On Sun, 8 Apr 2018 11:57:18 +0800, Zhang Zhuoyu wrote:
> > On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote:
> >
> > > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds);
> > > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds);
> > > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds);
> > >
> > > I don't think the in_cmds metric should be deleted here. It could be
> > > calculated on the fly via tx_cmds + rx_cmds + nodata_cmds.
> >
> > @Zhang Zhuoyu: How about something like the following?
> > https://git.samba.org/?pİiss/linux.git;a=commitdiff;hs723ccf433424721
> > 830797d70cfb88d4596e0fc
> >
>
> Mmm... This patch is much better.
> Looks good to me.
Looks like I never followed up with a proper submission for this patch.
I'll do so later today.
Cheers, David
prev parent reply other threads:[~2019-04-15 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 9:52 [PATCH 1/1] target:separate tx/rx cmd_puds Zhang Zhuoyu
2018-03-21 9:52 ` Zhang Zhuoyu
2018-04-05 11:12 ` David Disseldorp
2018-04-05 11:12 ` David Disseldorp
2018-04-06 12:09 ` David Disseldorp
2018-04-06 12:09 ` David Disseldorp
2018-04-08 3:57 ` Zhang Zhuoyu
2018-04-08 3:57 ` Zhang Zhuoyu
2018-04-08 3:57 ` Zhang Zhuoyu
2019-04-15 10:51 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415125138.2f0d09b7@suse.de \
--to=ddiss@suse.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.