From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3tQ-0005FD-M9 for qemu-devel@nongnu.org; Mon, 15 Apr 2019 11:51:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG3tP-00073T-Fq for qemu-devel@nongnu.org; Mon, 15 Apr 2019 11:51:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hG3tP-00071e-7B for qemu-devel@nongnu.org; Mon, 15 Apr 2019 11:51:35 -0400 Date: Mon, 15 Apr 2019 16:51:25 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20190415155125.GN5718@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20190415141547.15444-1-berrange@redhat.com> <0ade556d-bdf1-4440-472a-1e3e6cb7387a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0ade556d-bdf1-4440-472a-1e3e6cb7387a@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] vl: set LC_CTYPE early in main() for all code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Peter Maydell , QEMU Developers , Markus Armbruster , Bandan Das , Gerd Hoffmann , Samuel Thibault , Paolo Bonzini On Mon, Apr 15, 2019 at 10:25:03AM -0500, Eric Blake wrote: > On 4/15/19 9:25 AM, Peter Maydell wrote: > > On Mon, 15 Apr 2019 at 15:17, Daniel P. Berrang=C3=A9 wrote: > >> >=20 > > A few typo nits below... >=20 > Also: >=20 > >=20 > >> > >> + /* > >> + * Ideally we would set LC_ALL, but QEMU currently isn't able t= o cope > >> + * with arbitrary localization settings. In particular there ar= e two > >> + * known problems >=20 > "two known problems" but... >=20 > >> + * > >> + * - The QMP monitor needs to use the C locale rules for nume= ric > >> + * formatting. This would need a double/int -> string forma= tter > >> + * that is locale independant. > >=20 > > "independent" > >=20 > >> + * > >> + * - The QMP monitor needs to encode all data as UTF-8. This = needs > >> + * to be updated to use iconv(3) to explicitly convert the = current > >> + * locale's charset into utf-8 > >> + * > >> + * - Lots of codes uses is{upper,lower,alnum,...} functions, = expecting > >=20 > > "code" > >=20 > >> + * C locale sorting behaviour. Most QEMU usage should likel= y be > >> + * changed to g_ascii_is{upper,lower,alnum...} to match cod= e > >> + * assumptions, without being broken by locale settnigs. > >=20 > > "settings" >=20 > ...three bullet points. Heh, I knew I should have used "some" instead of "two" earlier when first writing this. It was inevitable I'd think of another problem to add :-) Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E61C10F0E for ; Mon, 15 Apr 2019 15:53:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BCAA20880 for ; Mon, 15 Apr 2019 15:53:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BCAA20880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:52119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3vI-00063t-8e for qemu-devel@archiver.kernel.org; Mon, 15 Apr 2019 11:53:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hG3tQ-0005FD-M9 for qemu-devel@nongnu.org; Mon, 15 Apr 2019 11:51:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hG3tP-00073T-Fq for qemu-devel@nongnu.org; Mon, 15 Apr 2019 11:51:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hG3tP-00071e-7B for qemu-devel@nongnu.org; Mon, 15 Apr 2019 11:51:35 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DF2E2D7ED; Mon, 15 Apr 2019 15:51:34 +0000 (UTC) Received: from redhat.com (unknown [10.42.22.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D1A019C77; Mon, 15 Apr 2019 15:51:28 +0000 (UTC) Date: Mon, 15 Apr 2019 16:51:25 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eric Blake Message-ID: <20190415155125.GN5718@redhat.com> References: <20190415141547.15444-1-berrange@redhat.com> <0ade556d-bdf1-4440-472a-1e3e6cb7387a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <0ade556d-bdf1-4440-472a-1e3e6cb7387a@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 15 Apr 2019 15:51:34 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2] vl: set LC_CTYPE early in main() for all code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , QEMU Developers , Markus Armbruster , Bandan Das , Gerd Hoffmann , Paolo Bonzini , Samuel Thibault Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190415155125.2OjaCimnHJk7toSgyr9A14Fh-h3R0Ja6XOyWJatQV6c@z> On Mon, Apr 15, 2019 at 10:25:03AM -0500, Eric Blake wrote: > On 4/15/19 9:25 AM, Peter Maydell wrote: > > On Mon, 15 Apr 2019 at 15:17, Daniel P. Berrang=C3=A9 wrote: > >> >=20 > > A few typo nits below... >=20 > Also: >=20 > >=20 > >> > >> + /* > >> + * Ideally we would set LC_ALL, but QEMU currently isn't able t= o cope > >> + * with arbitrary localization settings. In particular there ar= e two > >> + * known problems >=20 > "two known problems" but... >=20 > >> + * > >> + * - The QMP monitor needs to use the C locale rules for nume= ric > >> + * formatting. This would need a double/int -> string forma= tter > >> + * that is locale independant. > >=20 > > "independent" > >=20 > >> + * > >> + * - The QMP monitor needs to encode all data as UTF-8. This = needs > >> + * to be updated to use iconv(3) to explicitly convert the = current > >> + * locale's charset into utf-8 > >> + * > >> + * - Lots of codes uses is{upper,lower,alnum,...} functions, = expecting > >=20 > > "code" > >=20 > >> + * C locale sorting behaviour. Most QEMU usage should likel= y be > >> + * changed to g_ascii_is{upper,lower,alnum...} to match cod= e > >> + * assumptions, without being broken by locale settnigs. > >=20 > > "settings" >=20 > ...three bullet points. Heh, I knew I should have used "some" instead of "two" earlier when first writing this. It was inevitable I'd think of another problem to add :-) Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|