From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH libdrm] headers: Sync with drm-next Date: Mon, 15 Apr 2019 18:04:08 +0200 Message-ID: <20190415160408.GD2665@phenom.ffwll.local> References: <20190408205422.dj7z4dl36nauwlk7@intel.com> <1554809706-15389-1-git-send-email-ayan.halder@arm.com> <20190409115913.hvyjxlda4wtzm75t@intel.com> <20190409122710.k2bh25xg43lrqzvq@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: "freedreno@lists.freedesktop.org" , nd , "maxime.ripard@bootlin.com" , "intel-gfx@lists.freedesktop.org" , Liviu Dudau , "linux-kernel@vger.kernel.org" , Eric Engestrom , "airlied@linux.ie" , "malidp@foss.arm.com" , "dri-devel@lists.freedesktop.org" , "rodrigo.vivi@intel.com" , Ayan Halder , "sean@poorly.run" , "linux-arm-msm@vger.kernel.org" List-Id: linux-arm-msm@vger.kernel.org T24gV2VkLCBBcHIgMTAsIDIwMTkgYXQgMDk6NDk6MzNQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFR1ZSwgQXByIDksIDIwMTkgYXQgODoyNyBBTSBFcmljIEVuZ2VzdHJvbSA8ZXJpYy5l bmdlc3Ryb21AaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBUdWVzZGF5LCAyMDE5LTA0LTA5 IDEyOjU5OjEzICswMTAwLCBFcmljIEVuZ2VzdHJvbSB3cm90ZToKPiA+ID4gT24gVHVlc2RheSwg MjAxOS0wNC0wOSAxMTozNToxNCArMDAwMCwgQXlhbiBIYWxkZXIgd3JvdGU6Cj4gPiA+ID4gR2Vu ZXJhdGVkIHVzaW5nIG1ha2UgaGVhZGVyc19pbnN0YWxsIGZyb20gdGhlIGRybS1uZXh0Cj4gPiA+ ID4gdHJlZSAtIGdpdDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL2RybS9kcm0KPiA+ID4gPiBi cmFuY2ggLSBkcm0tbmV4dAo+ID4gPiA+IGNvbW1pdCAtIDE0ZDJiZDUzYTQ3YTdlMWNiM2UwM2Qw MGE2Yjk1MjczNGNmOTBmM2YKPiA+ID4gPgo+ID4gPiA+IFRoZSBjaGFuZ2VzIHdlcmUgYXMgZm9s bG93cyA6LQo+ID4gPiA+Cj4gPiA+ID4gY29yZTogKGRybS5oLCBkcm1fZm91cmNjLmgsIGRybV9t b2RlLmgpCj4gPiA+ID4gLSBBZGRlZCAnc3RydWN0IGRybV9zeW5jb2JqX3RyYW5zZmVyJywgJ3N0 cnVjdCBkcm1fc3luY29ial90aW1lbGluZV93YWl0JyBhbmQgJ3N0cnVjdCBkcm1fc3luY29ial90 aW1lbGluZV9hcnJheScKPiA+ID4gPiAtIEFkZGVkIHZhcmlvdXMgRFJNX0lPQ1RMX1NZTkNPQkpf IGlvY3Rscwo+ID4gPiA+IC0gQWRkZWQgc29tZSBuZXcgUkdCIGFuZCBZVVYgZm9ybWF0cwo+ID4g PiA+IC0gQWRkZWQgJ0RSTV9GT1JNQVRfTU9EX1ZFTkRPUl9BTExXSU5ORVInCj4gPiA+ID4gLSBB ZGRlZCAnU0FNU1VORycgYW5kIEFybSdzICdBRkJDJyBhbmQgJ0FMTFdJTk5FUicgZm9ybWF0IG1v ZGlmaWVycwo+ID4gPiA+IC0gQWRkZWQgJ3N0cnVjdCBkcm1fbW9kZV9yZWN0Jwo+ID4gPiA+Cj4g PiA+ID4gaTkxNToKPiA+ID4gPiAtIEFkZGVkIHN0cnVjdCAnc3RydWN0IGk5MTVfdXNlcl9leHRl bnNpb24nIGFuZCB2YXJpb3VzICdzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfJwo+ID4gPiA+ IC0gQWRkZWQgZGlmZmVyZW50IG1vZGVzIG9mIHBlci1wcm9jZXNzIEdyYXBoaWNzIFRyYW5zbGF0 aW9uIFRhYmxlCj4gPiA+ID4KPiA+ID4gPiBtc206Cj4gPiA+ID4gLSBBZGRlZCB2YXJpb3VzIGdl dCBvciBzZXQgR0VNIGJ1ZmZlciBpbmZvIGZsYWdzCj4gPiA+ID4gLSBBZGRlZCBzb21lIE1TTV9T VUJNSVRfQk9fIG1hY3Jvcwo+ID4gPiA+IC0gTW9kaWZpZWQgJ3N0cnVjdCBkcm1fbXNtX2dlbV9p bmZvJwo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQXlhbiBLdW1hciBoYWxkZXIgPGF5 YW4uaGFsZGVyQGFybS5jb20+Cj4gPiA+Cj4gPiA+IFRoaXMgbG9va3Mgc2FuZSwgYW5kIGFwcGxp ZXMgY2xlYW5seSA6KQo+ID4gPiBBY2tlZC1ieTogRXJpYyBFbmdlc3Ryb20gPGVyaWMuZW5nZXN0 cm9tQGludGVsLmNvbT4KPiA+Cj4gPiBBY3R1YWxseSwgcmV2b2tpbmcgdGhhdCwgYXMgdGhpcyBw YXRjaCBicmVha3MgdGhlIGJ1aWxkOyBzZWUgYmVsb3cuCj4gPgo+ID4gPgo+ID4gPiA+IC0tLQo+ ID4gPiA+ICBpbmNsdWRlL2RybS9kcm0uaCAgICAgICAgfCAgMzYgKysrKysrKwo+ID4gPiA+ICBp bmNsdWRlL2RybS9kcm1fZm91cmNjLmggfCAxMzYgKysrKysrKysrKysrKysrKysrKysrKysrKysr Cj4gPiA+ID4gIGluY2x1ZGUvZHJtL2RybV9tb2RlLmggICB8ICAyMyArKysrLQo+ID4gPiA+ICBp bmNsdWRlL2RybS9pOTE1X2RybS5oICAgfCAyMzcgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0KPiA+ID4gPiAgaW5jbHVkZS9kcm0vbXNtX2RybS5oICAgIHwg IDI1ICsrKy0tCj4gPiA+ID4gIDUgZmlsZXMgY2hhbmdlZCwgNDE1IGluc2VydGlvbnMoKyksIDQy IGRlbGV0aW9ucygtKQo+ID4gPiA+Cj4gPiBbc25pcF0KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvaW5j bHVkZS9kcm0vbXNtX2RybS5oIGIvaW5jbHVkZS9kcm0vbXNtX2RybS5oCj4gPiA+ID4gaW5kZXgg YzA2ZDBhNS4uOTFhMTZiMyAxMDA2NDQKPiA+ID4gPiAtLS0gYS9pbmNsdWRlL2RybS9tc21fZHJt LmgKPiA+ID4gPiArKysgYi9pbmNsdWRlL2RybS9tc21fZHJtLmgKPiA+ID4gPiBAQCAtMTA1LDE0 ICsxMDUsMjQgQEAgc3RydWN0IGRybV9tc21fZ2VtX25ldyB7Cj4gPiA+ID4gICAgIF9fdTMyIGhh bmRsZTsgICAgICAgICAvKiBvdXQgKi8KPiA+ID4gPiAgfTsKPiA+ID4gPgo+ID4gPiA+IC0jZGVm aW5lIE1TTV9JTkZPX0lPVkEgICAgICAweDAxCj4gPiA+ID4gLQo+ID4gPiA+IC0jZGVmaW5lIE1T TV9JTkZPX0ZMQUdTIChNU01fSU5GT19JT1ZBKQo+ID4gPiA+ICsvKiBHZXQgb3Igc2V0IEdFTSBi dWZmZXIgaW5mby4gIFRoZSByZXF1ZXN0ZWQgdmFsdWUgY2FuIGJlIHBhc3NlZAo+ID4gPiA+ICsg KiBkaXJlY3RseSBpbiAndmFsdWUnLCBvciBmb3IgZGF0YSBsYXJnZXIgdGhhbiA2NGIgJ3ZhbHVl JyBpcyBhCj4gPiA+ID4gKyAqIHBvaW50ZXIgdG8gdXNlcnNwYWNlIGJ1ZmZlciwgd2l0aCAnbGVu JyBzcGVjaWZ5aW5nIHRoZSBudW1iZXIgb2YKPiA+ID4gPiArICogYnl0ZXMgY29waWVkIGludG8g dGhhdCBidWZmZXIuICBGb3IgaW5mbyByZXR1cm5lZCBieSBwb2ludGVyLAo+ID4gPiA+ICsgKiBj YWxsaW5nIHRoZSBHRU1fSU5GTyBpb2N0bCB3aXRoIG51bGwgJ3ZhbHVlJyB3aWxsIHJldHVybiB0 aGUKPiA+ID4gPiArICogcmVxdWlyZWQgYnVmZmVyIHNpemUgaW4gJ2xlbicKPiA+ID4gPiArICov Cj4gPiA+ID4gKyNkZWZpbmUgTVNNX0lORk9fR0VUX09GRlNFVCAgICAgICAgMHgwMCAgIC8qIGdl dCBtbWFwKCkgb2Zmc2V0LCByZXR1cm5lZCBieSB2YWx1ZSAqLwo+ID4gPiA+ICsjZGVmaW5lIE1T TV9JTkZPX0dFVF9JT1ZBICAweDAxICAgLyogZ2V0IGlvdmEsIHJldHVybmVkIGJ5IHZhbHVlICov Cj4gPiA+ID4gKyNkZWZpbmUgTVNNX0lORk9fU0VUX05BTUUgIDB4MDIgICAvKiBzZXQgdGhlIGRl YnVnIG5hbWUgKGJ5IHBvaW50ZXIpICovCj4gPiA+ID4gKyNkZWZpbmUgTVNNX0lORk9fR0VUX05B TUUgIDB4MDMgICAvKiBnZXQgZGVidWcgbmFtZSwgcmV0dXJuZWQgYnkgcG9pbnRlciAqLwo+ID4g PiA+Cj4gPiA+ID4gIHN0cnVjdCBkcm1fbXNtX2dlbV9pbmZvIHsKPiA+ID4gPiAgICAgX191MzIg aGFuZGxlOyAgICAgICAgIC8qIGluICovCj4gPiA+ID4gLSAgIF9fdTMyIGZsYWdzOyAgICAgICAg ICAvKiBpbiAtIGNvbWJpbmF0aW9uIG9mIE1TTV9JTkZPXyogZmxhZ3MgKi8KPiA+ID4gPiAtICAg X191NjQgb2Zmc2V0OyAgICAgICAgIC8qIG91dCwgbW1hcCgpIG9mZnNldCBvciBpb3ZhICovCj4g PiA+ID4gKyAgIF9fdTMyIGluZm87ICAgICAgICAgICAvKiBpbiAtIG9uZSBvZiBNU01fSU5GT18q ICovCj4gPiA+ID4gKyAgIF9fdTY0IHZhbHVlOyAgICAgICAgICAvKiBpbiBvciBvdXQgKi8KPiA+ ID4gPiArICAgX191MzIgbGVuOyAgICAgICAgICAgIC8qIGluIG9yIG91dCAqLwo+ID4gPiA+ICsg ICBfX3UzMiBwYWQ7Cj4gPgo+ID4gZnJlZWRyZW5vL21zbS9tc21fYm8uYyBuZWVkcyB0byBiZSB1 cGRhdGVkIHRvIHJlZmxlY3QgdGhvc2UgY2hhbmdlcy4KPiAKPiAKPiBJIHRoaW5rIHlvdSBjYW4g anVzdCByZW5hbWUgZmxhZ3MtPmluZm8gYW5kIG9mZnNldC0+dmFsdWUsIHRoZSByZXN0IG9mCj4g dGhlIHN0cnVjdCBzaG91bGQgYmUgemVyby1pbml0aWFsaXplZC4uIGlmIGluIGRvdWJ0IHlvdSBj YW4gY2hlY2sKPiAkbWVzYS9zcmMvZnJlZWRyZW5vL2RybS9tc21fYm8uYwo+IAo+IHNpZGUtbm90 ZTogIHRoZSBsaWJkcm1fZnJlZWRyZW5vIGNvZGUgd2FzIGZvbGRlZCBpbnRvIG1lc2EgaW4gMTku MCwgc28KPiBhdCAqc29tZSogcG9pbnQgd2UgY2FuIHByb2JhYmx5IGRpc2FibGUgbGliZHJtX2Zy ZWVkcmVubyBidWlsZCBieQo+IGRlZmF1bHQuICAoSSdkIGtpbmRhIHN0aWxsIGxpa2UgdG8ga2Vl cCB0aGUgY29kZSBhcm91bmQgZm9yIHNvbWUgbWlzYwo+IHN0YW5kYWxvbmUgdG9vbHMgSSBoYXZl LCBidXQgdGhhdCBpcyB0aGUgc29ydCBvZiB0aGluZyB3aGVyZSBJIGNhbiBmaXgKPiBsaWJkcm0g aWYgaXQgZ2V0cyBicm9rZW4pLiAgV2hlbiB0byBzd2l0Y2ggdG8gZGlzYWJsZWQgYnkgZGVmYXVs dCBJCj4gZ3Vlc3MgY29tZXMgZG93biB0byBob3cgbG9uZyB3ZSB3YW50IHRvIHN1cHBvcnQgbWVz YSAxOC54IHdpdGggbGF0ZXN0Cj4gbGliZHJtPz8gIE1heWJlIGFmdGVyIDE5LjEsIHNpbmNlIChz ZWxmaXNobHkgbW90aXZhdGVkKSB0aGF0IGdpdmVzIG1lCj4gYSBsb25nIGVub3VnaCB3aW5kb3cg YmFjayBpbiBjYXNlIEkgZmluZCBteXNlbGYgbmVlZGluZyB0byBiaXNlY3QgZm9yCj4gc29tZSBy ZWdyZXNzaW9uLi4KClNpZGVub3RlOiByZW5hbWluZyBmaWVsZHMgYnJlYWtzIHVhcGkgKGJ1dCBu b3QgdWFiaSksIHNvIG5vdCByZWFsbHkgZ3JlYXQuCkV2ZW4gaWYgaXQgZG9lc24ndCBtYXR0ZXIg Zm9yIHlvdSBzaW5jZSB5b3UgY29weXBhc3RlZCB0aGUgaGVhZGVycyBpbnRvCm1lc2EgLi4uIERv bnQgZG8gdGhpcywgaXQncyByZWdyZXRzIDotKQoKSWYgeW91IHdhbnQgdG8gZG8gcmVuYW1lIHVh cGkgd2l0aG91dCBicmVha2luZyBzdHVmZiwgY3JlYXRlIGEgbmV3CnN0cnVjdHVyZSB3aXRoIG5l dyBmaWVsZCBuYW1lcywgdGhhdCBoYXBwZW5zIHRvIG1hdGNoIHRoZSBvbGQgb25lLiBQbHVzCmFk ZCBhIGNvbW1lbnQuIFNvCgpzdHJ1Y3QgZHJtX21zbV9nZW1faW5mbzIgewogICBfX3UzMiBoYW5k bGU7ICAgICAgICAgLyogaW4gKi8KICAgX191MzIgaW5mbzsgICAgICAgICAgIC8qIGluIC0gb25l IG9mIE1TTV9JTkZPXyogKi8KICAgX191NjQgdmFsdWU7ICAgICAgICAgIC8qIGluIG9yIG91dCAq LwogICBfX3UzMiBsZW47ICAgICAgICAgICAgLyogaW4gb3Igb3V0ICovCiAgIF9fdTMyIHBhZDsK fTsKCllvdSBjYW4ganVzdCB1c2UgdGhhdCBzdHJ1Y3QgaW4gdGhlIElPQ1RMIG51bWJlciBkZWZp bmUsIHN0dWZmIHdpbGwgd29yawpvdXQgY29ycmVjdGx5ICh3ZSBkb24ndCB0eXBlY2hlY2sgdGhl c2UgaW4gdXNlcnNwYWNlLCBhbmQgbGVuZ2h0Cm1pc21hdGNoZXMgYXJlIGhhbmRsZWQgYnkgdGhl IGtlcm5lbCBhdXRvbWF0aWNhbGx5IGFueXdheSkuCgotRGFuaWVsCgo+IAo+IEJSLAo+IC1SCj4g Cj4gPgo+ID4gPiA+ICB9Owo+ID4gPiA+Cj4gPiA+ID4gICNkZWZpbmUgTVNNX1BSRVBfUkVBRCAg ICAgICAgMHgwMQo+ID4gPiA+IEBAIC0xODgsOCArMTk4LDExIEBAIHN0cnVjdCBkcm1fbXNtX2dl bV9zdWJtaXRfY21kIHsKPiA+ID4gPiAgICovCj4gPiA+ID4gICNkZWZpbmUgTVNNX1NVQk1JVF9C T19SRUFEICAgICAgICAgICAgIDB4MDAwMQo+ID4gPiA+ICAjZGVmaW5lIE1TTV9TVUJNSVRfQk9f V1JJVEUgICAgICAgICAgICAweDAwMDIKPiA+ID4gPiArI2RlZmluZSBNU01fU1VCTUlUX0JPX0RV TVAgICAgICAgICAgICAgMHgwMDA0Cj4gPiA+ID4KPiA+ID4gPiAtI2RlZmluZSBNU01fU1VCTUlU X0JPX0ZMQUdTICAgICAgICAgICAgKE1TTV9TVUJNSVRfQk9fUkVBRCB8IE1TTV9TVUJNSVRfQk9f V1JJVEUpCj4gPiA+ID4gKyNkZWZpbmUgTVNNX1NVQk1JVF9CT19GTEFHUyAgICAgICAgICAgIChN U01fU1VCTUlUX0JPX1JFQUQgfCBcCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgTVNNX1NVQk1JVF9CT19XUklURSB8IFwKPiA+ID4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBNU01fU1VCTUlUX0JPX0RVTVApCj4gPiA+ID4KPiA+ID4gPiAg c3RydWN0IGRybV9tc21fZ2VtX3N1Ym1pdF9ibyB7Cj4gPiA+ID4gICAgIF9fdTMyIGZsYWdzOyAg ICAgICAgICAvKiBpbiwgbWFzayBvZiBNU01fU1VCTUlUX0JPX3ggKi8KPiA+ID4gPiAtLQo+ID4g PiA+IDIuNy40Cj4gPiA+ID4KCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB7BAC10F0E for ; Mon, 15 Apr 2019 16:04:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82CD320684 for ; Mon, 15 Apr 2019 16:04:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="au2i07l+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727618AbfDOQEN (ORCPT ); Mon, 15 Apr 2019 12:04:13 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:35455 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727568AbfDOQEN (ORCPT ); Mon, 15 Apr 2019 12:04:13 -0400 Received: by mail-ed1-f68.google.com with SMTP id y67so1908528ede.2 for ; Mon, 15 Apr 2019 09:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=tGLBZWP5CXRLK+Kp3DeCDIiMD+kvtL4Oy1cNPUHhImM=; b=au2i07l+BH5G6hauFkZj6L5aemQddnsks8qXaKQZhKed6mkNoNwa5YGt9h12NhOa4G 0y/kBCoklawMqX2SVFUbrB+9yvmfHAnyT8BuOREMseZnIuL/T1/uALktFvvqUlaMTqs/ 8JJ4jo9VR4fDoLwUIoI/kvm0GUldJ/Pwrz2tM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=tGLBZWP5CXRLK+Kp3DeCDIiMD+kvtL4Oy1cNPUHhImM=; b=hJIUdHBntgQCUxUMkvTaPkoc5tuQu+OXv5gjbHE2EcOrASqAkT8DrN9WRMd+EODrzz lSdSSt8RQGWAHWTksNj192TEAtwArYyMafiuy/OcLECa8SPMuwx2beOuJ6804HxZFfBO PD0UaBjD/eJ7X0KDu648zuiNSofEM1BT+OkdWqbOITe/GymwGbmEbMWUYqpm/ZXNk6k4 u0pSPbgp7Ih4eET5IVGu7owKTJmh+EY8HRG6D0mO5dhrwDr9z3xUP0/jo+0tVCEJQc4J gaJIIV1B6Wafk8DkF/3bgC+WkYzMg7WFZ+nHkw7D7lE66Likul/dZqo2tMRdsM5U32Od zJRg== X-Gm-Message-State: APjAAAV7A7/QxfxRua7iDKQqNp5O3c6Mel+9jfyrWmetiw35S4o0rG0j 1PZOuUvpxzJetiwfML9J5lb4/w== X-Google-Smtp-Source: APXvYqzs0ChClUmXAn/RBb3VUCtx6B3qBGte1kdDH1D2N1ZvBiC8bjP6ljwqmr4t5ap5En15pyzeSw== X-Received: by 2002:a17:906:7f93:: with SMTP id f19mr22082642ejr.75.1555344251297; Mon, 15 Apr 2019 09:04:11 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id y12sm3726607edh.29.2019.04.15.09.04.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 09:04:10 -0700 (PDT) Date: Mon, 15 Apr 2019 18:04:08 +0200 From: Daniel Vetter To: Rob Clark Cc: Eric Engestrom , Ayan Halder , Liviu Dudau , Brian Starkey , "malidp@foss.arm.com" , "maarten.lankhorst@linux.intel.com" , "maxime.ripard@bootlin.com" , "sean@poorly.run" , "airlied@linux.ie" , "daniel@ffwll.ch" , "jani.nikula@linux.intel.com" , "joonas.lahtinen@linux.intel.com" , "rodrigo.vivi@intel.com" , "intel-gfx@lists.freedesktop.org" , "linux-arm-msm@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "freedreno@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , nd Subject: Re: [PATCH libdrm] headers: Sync with drm-next Message-ID: <20190415160408.GD2665@phenom.ffwll.local> Mail-Followup-To: Rob Clark , Eric Engestrom , Ayan Halder , Liviu Dudau , Brian Starkey , "malidp@foss.arm.com" , "maarten.lankhorst@linux.intel.com" , "maxime.ripard@bootlin.com" , "sean@poorly.run" , "airlied@linux.ie" , "jani.nikula@linux.intel.com" , "joonas.lahtinen@linux.intel.com" , "rodrigo.vivi@intel.com" , "intel-gfx@lists.freedesktop.org" , "linux-arm-msm@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "freedreno@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , nd References: <20190408205422.dj7z4dl36nauwlk7@intel.com> <1554809706-15389-1-git-send-email-ayan.halder@arm.com> <20190409115913.hvyjxlda4wtzm75t@intel.com> <20190409122710.k2bh25xg43lrqzvq@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.19.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Message-ID: <20190415160408.8pyfQ-0M2D9Rk_UEcZmYSBF9aw6EDxkIGZJstZb4EiI@z> On Wed, Apr 10, 2019 at 09:49:33PM -0400, Rob Clark wrote: > On Tue, Apr 9, 2019 at 8:27 AM Eric Engestrom wrote: > > > > On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote: > > > On Tuesday, 2019-04-09 11:35:14 +0000, Ayan Halder wrote: > > > > Generated using make headers_install from the drm-next > > > > tree - git://anongit.freedesktop.org/drm/drm > > > > branch - drm-next > > > > commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f > > > > > > > > The changes were as follows :- > > > > > > > > core: (drm.h, drm_fourcc.h, drm_mode.h) > > > > - Added 'struct drm_syncobj_transfer', 'struct drm_syncobj_timeline_wait' and 'struct drm_syncobj_timeline_array' > > > > - Added various DRM_IOCTL_SYNCOBJ_ ioctls > > > > - Added some new RGB and YUV formats > > > > - Added 'DRM_FORMAT_MOD_VENDOR_ALLWINNER' > > > > - Added 'SAMSUNG' and Arm's 'AFBC' and 'ALLWINNER' format modifiers > > > > - Added 'struct drm_mode_rect' > > > > > > > > i915: > > > > - Added struct 'struct i915_user_extension' and various 'struct drm_i915_gem_context_' > > > > - Added different modes of per-process Graphics Translation Table > > > > > > > > msm: > > > > - Added various get or set GEM buffer info flags > > > > - Added some MSM_SUBMIT_BO_ macros > > > > - Modified 'struct drm_msm_gem_info' > > > > > > > > Signed-off-by: Ayan Kumar halder > > > > > > This looks sane, and applies cleanly :) > > > Acked-by: Eric Engestrom > > > > Actually, revoking that, as this patch breaks the build; see below. > > > > > > > > > --- > > > > include/drm/drm.h | 36 +++++++ > > > > include/drm/drm_fourcc.h | 136 +++++++++++++++++++++++++++ > > > > include/drm/drm_mode.h | 23 ++++- > > > > include/drm/i915_drm.h | 237 ++++++++++++++++++++++++++++++++++++++++------- > > > > include/drm/msm_drm.h | 25 +++-- > > > > 5 files changed, 415 insertions(+), 42 deletions(-) > > > > > > [snip] > > > > diff --git a/include/drm/msm_drm.h b/include/drm/msm_drm.h > > > > index c06d0a5..91a16b3 100644 > > > > --- a/include/drm/msm_drm.h > > > > +++ b/include/drm/msm_drm.h > > > > @@ -105,14 +105,24 @@ struct drm_msm_gem_new { > > > > __u32 handle; /* out */ > > > > }; > > > > > > > > -#define MSM_INFO_IOVA 0x01 > > > > - > > > > -#define MSM_INFO_FLAGS (MSM_INFO_IOVA) > > > > +/* Get or set GEM buffer info. The requested value can be passed > > > > + * directly in 'value', or for data larger than 64b 'value' is a > > > > + * pointer to userspace buffer, with 'len' specifying the number of > > > > + * bytes copied into that buffer. For info returned by pointer, > > > > + * calling the GEM_INFO ioctl with null 'value' will return the > > > > + * required buffer size in 'len' > > > > + */ > > > > +#define MSM_INFO_GET_OFFSET 0x00 /* get mmap() offset, returned by value */ > > > > +#define MSM_INFO_GET_IOVA 0x01 /* get iova, returned by value */ > > > > +#define MSM_INFO_SET_NAME 0x02 /* set the debug name (by pointer) */ > > > > +#define MSM_INFO_GET_NAME 0x03 /* get debug name, returned by pointer */ > > > > > > > > struct drm_msm_gem_info { > > > > __u32 handle; /* in */ > > > > - __u32 flags; /* in - combination of MSM_INFO_* flags */ > > > > - __u64 offset; /* out, mmap() offset or iova */ > > > > + __u32 info; /* in - one of MSM_INFO_* */ > > > > + __u64 value; /* in or out */ > > > > + __u32 len; /* in or out */ > > > > + __u32 pad; > > > > freedreno/msm/msm_bo.c needs to be updated to reflect those changes. > > > I think you can just rename flags->info and offset->value, the rest of > the struct should be zero-initialized.. if in doubt you can check > $mesa/src/freedreno/drm/msm_bo.c > > side-note: the libdrm_freedreno code was folded into mesa in 19.0, so > at *some* point we can probably disable libdrm_freedreno build by > default. (I'd kinda still like to keep the code around for some misc > standalone tools I have, but that is the sort of thing where I can fix > libdrm if it gets broken). When to switch to disabled by default I > guess comes down to how long we want to support mesa 18.x with latest > libdrm?? Maybe after 19.1, since (selfishly motivated) that gives me > a long enough window back in case I find myself needing to bisect for > some regression.. Sidenote: renaming fields breaks uapi (but not uabi), so not really great. Even if it doesn't matter for you since you copypasted the headers into mesa ... Dont do this, it's regrets :-) If you want to do rename uapi without breaking stuff, create a new structure with new field names, that happens to match the old one. Plus add a comment. So struct drm_msm_gem_info2 { __u32 handle; /* in */ __u32 info; /* in - one of MSM_INFO_* */ __u64 value; /* in or out */ __u32 len; /* in or out */ __u32 pad; }; You can just use that struct in the IOCTL number define, stuff will work out correctly (we don't typecheck these in userspace, and lenght mismatches are handled by the kernel automatically anyway). -Daniel > > BR, > -R > > > > > > > }; > > > > > > > > #define MSM_PREP_READ 0x01 > > > > @@ -188,8 +198,11 @@ struct drm_msm_gem_submit_cmd { > > > > */ > > > > #define MSM_SUBMIT_BO_READ 0x0001 > > > > #define MSM_SUBMIT_BO_WRITE 0x0002 > > > > +#define MSM_SUBMIT_BO_DUMP 0x0004 > > > > > > > > -#define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | MSM_SUBMIT_BO_WRITE) > > > > +#define MSM_SUBMIT_BO_FLAGS (MSM_SUBMIT_BO_READ | \ > > > > + MSM_SUBMIT_BO_WRITE | \ > > > > + MSM_SUBMIT_BO_DUMP) > > > > > > > > struct drm_msm_gem_submit_bo { > > > > __u32 flags; /* in, mask of MSM_SUBMIT_BO_x */ > > > > -- > > > > 2.7.4 > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch