From: Daniel Vetter <daniel@ffwll.ch>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Paul Cercueil <paul@crapouillou.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sean Paul <sean@poorly.run>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs
Date: Mon, 15 Apr 2019 18:09:17 +0200 [thread overview]
Message-ID: <20190415160917.GF2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190316215944.GB11309@ravnborg.org>
On Sat, Mar 16, 2019 at 10:59:44PM +0100, Sam Ravnborg wrote:
> > + ret = drm_fbdev_generic_setup(drm, 16);
> > + if (ret) {
> > + dev_err(dev, "Failed to init fbdev\n");
> > + goto err_devclk_disable;
> > + }
> fbdev is usually considered an optionl feature that do not prevent
> the display driver from loading.
> Consider what to do in the error case.
Drive-through comment: Totally ok to require this, failing here usually
means you have a driver bug somewhere. fbdev is optional as in Kconfig
optional, but people who enable it generally need it.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-04-15 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 17:06 [PATCH v2 1/3] dt-bindings: Add doc for the ingenic-drm driver Paul Cercueil
2019-03-15 17:07 ` [PATCH v2 2/3] dt-bindings: Add header for the ingenic-drm driver bindings Paul Cercueil
2019-03-15 17:07 ` [PATCH v2 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs Paul Cercueil
2019-03-16 21:59 ` Sam Ravnborg
2019-03-16 21:59 ` Sam Ravnborg
2019-03-17 1:14 ` Paul Cercueil
2019-04-02 16:16 ` Paul Cercueil
2019-04-15 16:09 ` Daniel Vetter [this message]
2019-03-16 12:29 ` [PATCH v2 1/3] dt-bindings: Add doc for the ingenic-drm driver Paul Cercueil
2019-03-16 20:59 ` Sam Ravnborg
2019-03-16 20:59 ` Sam Ravnborg
2019-03-16 21:56 ` Paul Cercueil
2019-03-16 21:56 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415160917.GF2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.