From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: Finish the irq ack+handler split for ilk+
Date: Mon, 15 Apr 2019 20:04:55 +0300 [thread overview]
Message-ID: <20190415170455.GE24299@intel.com> (raw)
In-Reply-To: <155534717157.22690.12080075921548880545@skylake-alporthouse-com>
On Mon, Apr 15, 2019 at 05:52:51PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2019-04-15 16:49:04)
> > static irqreturn_t
> > -gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl)
> > +gen8_de_irq_handler(struct drm_i915_private *dev_priv, u32 master_ctl,
> > + const struct gen8_de_irq_regs *de,
> > + const struct pch_irq_regs *pch)
> > {
> > }
> >
> > if (INTEL_GEN(dev_priv) >= 11 && (master_ctl & GEN11_DE_HPD_IRQ)) {
>
> Can GEN11_DE_HPD_IRQ be raised on any other platform?
Looks like the bit wasn't used pre-icl.
>
> Lgtm,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-15 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 15:49 [PATCH 0/4] drm/i915: Finish the ack+handler split for irq handler Ville Syrjala
2019-04-15 15:49 ` [PATCH 1/4] drm/i915: Add gen8_de_pipe_fault_mask() Ville Syrjala
2019-04-15 16:37 ` Chris Wilson
2019-04-15 15:49 ` [PATCH 2/4] drm/i915: Introduce struct hpd_irq_regs Ville Syrjala
2019-04-15 16:45 ` Chris Wilson
2019-04-15 15:49 ` [PATCH 3/4] drm/i915: Split pch irq handling to ack+handler Ville Syrjala
2019-04-15 16:48 ` Chris Wilson
2019-04-15 16:56 ` Ville Syrjälä
2019-04-15 15:49 ` [PATCH 4/4] drm/i915: Finish the irq ack+handler split for ilk+ Ville Syrjala
2019-04-15 16:52 ` Chris Wilson
2019-04-15 17:04 ` Ville Syrjälä [this message]
2019-04-15 15:55 ` [PATCH 0/4] drm/i915: Finish the ack+handler split for irq handler Chris Wilson
2019-04-15 16:36 ` Ville Syrjälä
2019-04-15 16:33 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-04-15 18:25 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415170455.GE24299@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.