From: Marcelo Tosatti <mtosatti@redhat.com>
To: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Haris Okanovic <haris.okanovic@ni.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 2/3] timers: do not raise softirq unconditionally (spinlockless version)
Date: Mon, 15 Apr 2019 17:12:15 -0300 [thread overview]
Message-ID: <20190415201429.427759476@amt.cnet> (raw)
In-Reply-To: 20190415201213.600254019@amt.cnet
[-- Attachment #1: 02-do-not-raise-softirq-unconditionally-second-attempt --]
[-- Type: text/plain, Size: 1162 bytes --]
Check base->pending_map locklessly and skip raising timer softirq
if empty.
What allows the lockless (and potentially racy against mod_timer)
check is that mod_timer will raise another timer softirq after
modifying base->pending_map.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
---
kernel/time/timer.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
Index: linux-rt-devel/kernel/time/timer.c
===================================================================
--- linux-rt-devel.orig/kernel/time/timer.c 2019-04-15 14:21:02.788704354 -0300
+++ linux-rt-devel/kernel/time/timer.c 2019-04-15 14:22:56.755047354 -0300
@@ -1776,6 +1776,24 @@
if (time_before(jiffies, base->clk))
return;
}
+
+#ifdef CONFIG_PREEMPT_RT_FULL
+/* On RT, irq work runs from softirq */
+ if (irq_work_needs_cpu())
+ goto raise;
+#endif
+ base = this_cpu_ptr(&timer_bases[BASE_STD]);
+ if (!housekeeping_cpu(base->cpu, HK_FLAG_TIMER)) {
+ if (!bitmap_empty(base->pending_map, WHEEL_SIZE))
+ goto raise;
+ base++;
+ if (!bitmap_empty(base->pending_map, WHEEL_SIZE))
+ goto raise;
+
+ return;
+ }
+
+raise:
raise_softirq(TIMER_SOFTIRQ);
}
next prev parent reply other threads:[~2019-04-15 20:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 20:12 [patch 0/3] do not raise timer softirq unconditionally (spinlockless version) Marcelo Tosatti
2019-04-15 20:12 ` [patch 1/3] timers: raise timer softirq on __mod_timer/add_timer_on Marcelo Tosatti
2019-05-29 14:53 ` Anna-Maria Gleixner
2019-05-30 19:23 ` Marcelo Tosatti
2019-04-15 20:12 ` Marcelo Tosatti [this message]
2019-05-29 14:53 ` [patch 2/3] timers: do not raise softirq unconditionally (spinlockless version) Anna-Maria Gleixner
2019-05-30 20:14 ` Marcelo Tosatti
2019-05-31 11:55 ` Anna-Maria Gleixner
2019-06-11 11:45 ` Anna-Maria Gleixner
2019-06-04 6:29 ` Peter Xu
2019-06-06 15:14 ` Marcelo Tosatti
2019-04-15 20:12 ` [patch 3/3] timers: condense pending bitmap information Marcelo Tosatti
2019-04-15 20:17 ` [patch 0/3] do not raise timer softirq unconditionally (spinlockless version) Marcelo Tosatti
2019-05-06 3:22 ` Marcelo Tosatti
2019-05-06 7:17 ` Daniel Bristot de Oliveira
2019-05-06 9:22 ` Thomas Gleixner
2019-05-29 14:52 ` Anna-Maria Gleixner
2019-05-30 19:38 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415201429.427759476@amt.cnet \
--to=mtosatti@redhat.com \
--cc=anna-maria@linutronix.de \
--cc=bristot@redhat.com \
--cc=haris.okanovic@ni.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.