From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] package/autoconf: Add hash for license files
Date: Mon, 15 Apr 2019 21:36:37 +0200 [thread overview]
Message-ID: <20190415213637.715a8dbb@windsurf> (raw)
In-Reply-To: <20190415181517.83400-1-aduskett@gmail.com>
Hello Adam,
On Mon, 15 Apr 2019 14:15:14 -0400
aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> package/autoconf/autoconf.hash | 2 ++
> 1 file changed, 2 insertions(+)
Series applied, thanks. To make this series even better, here are some
things that would have been nice:
- Use a lower-case letter to start the commit title, i.e "add hash"
instead of "Add hash"
- Don't make unrelated changes, such as changing the indentation of
the existing hashes.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-04-15 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 18:15 [Buildroot] [PATCH 1/4] package/autoconf: Add hash for license files aduskett at gmail.com
2019-04-15 18:15 ` [Buildroot] [PATCH 2/4] package/libtool: " aduskett at gmail.com
2019-04-15 18:15 ` [Buildroot] [PATCH 3/4] package/ninja: " aduskett at gmail.com
2019-04-15 18:15 ` [Buildroot] [PATCH 4/4] package/tar: " aduskett at gmail.com
2019-04-15 19:36 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415213637.715a8dbb@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.