All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.com>,
	Krzysztof Adamski <krzysztof.adamski@nokia.com>
Subject: Re: [PATCH] hwmon: Add support for samples attributes
Date: Mon, 15 Apr 2019 14:47:16 -0700	[thread overview]
Message-ID: <20190415214715.GA11156@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <1555360032-31159-1-git-send-email-linux@roeck-us.net>

Thanks for adding this.

On Mon, Apr 15, 2019 at 01:27:12PM -0700, Guenter Roeck wrote:
> Add support for the new samples attributes to the hwmon core.
> 
> Cc: Krzysztof Adamski <krzysztof.adamski@nokia.com>
> Cc: Nicolin Chen <nicoleotsuka@gmail.com>

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

Will redo my change and test through API later.

> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/hwmon/hwmon.c |  5 +++++
>  include/linux/hwmon.h | 11 +++++++++++
>  2 files changed, 16 insertions(+)

> diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
> index 7a8cc06a0d61..7b18a6150a11 100644
> --- a/include/linux/hwmon.h
> +++ b/include/linux/hwmon.h
> @@ -40,6 +40,12 @@ enum hwmon_chip_attributes {
>  	hwmon_chip_register_tz,
>  	hwmon_chip_update_interval,
>  	hwmon_chip_alarms,
> +	hwmon_chip_samples,
> +	hwmon_chip_curr_samples,
> +	hwmon_chip_in_samples,
> +	hwmon_chip_power_samples,
> +	hwmon_chip_temp_samples,
> +
>  };

Why add a blank line at the end?

  reply	other threads:[~2019-04-15 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15 20:27 [PATCH] hwmon: Add support for samples attributes Guenter Roeck
2019-04-15 21:47 ` Nicolin Chen [this message]
2019-04-15 22:00   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190415214715.GA11156@Asurada-Nvidia.nvidia.com \
    --to=nicoleotsuka@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=krzysztof.adamski@nokia.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.