From: Daniel Vetter <daniel@ffwll.ch>
To: Deepak Singh Rawat <drawat@vmware.com>
Cc: Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only
Date: Tue, 16 Apr 2019 09:42:07 +0200 [thread overview]
Message-ID: <20190416074207.GP2665@phenom.ffwll.local> (raw)
In-Reply-To: <20190415172814.9840-1-drawat@vmware.com>
On Mon, Apr 15, 2019 at 05:28:05PM +0000, Deepak Singh Rawat wrote:
> Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
> user-space, so no point exposing it otherwise.
>
> Signed-off-by: Deepak Rawat <drawat@vmware.com>
> Fixes: d3b21767821e ("drm: Add a new plane property to send damage during plane update")
Makes sense, probably good if we add Cc: stable@vger.kernel.org too
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
btw, want drm-misc commit rights to push this? Assuming you'd then push
vmware drm patches in general ofc. See
https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
Cheers, Daniel
> ---
> drivers/gpu/drm/drm_mode_config.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index 4a1c2023ccf0..1a346ae1599d 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
> @@ -297,8 +297,9 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
> return -ENOMEM;
> dev->mode_config.prop_crtc_id = prop;
>
> - prop = drm_property_create(dev, DRM_MODE_PROP_BLOB, "FB_DAMAGE_CLIPS",
> - 0);
> + prop = drm_property_create(dev,
> + DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
> + "FB_DAMAGE_CLIPS", 0);
> if (!prop)
> return -ENOMEM;
> dev->mode_config.prop_fb_damage_clips = prop;
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-16 7:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 17:28 [PATCH] drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only Deepak Singh Rawat
2019-04-16 7:42 ` Daniel Vetter [this message]
2019-04-16 16:21 ` Deepak Singh Rawat
2019-04-16 18:15 ` Daniel Vetter
2019-04-16 18:28 ` Deepak Singh Rawat
2019-04-16 19:27 ` Daniel Vetter
2019-04-16 22:34 ` Deepak Singh Rawat
2019-04-17 7:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416074207.GP2665@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Linux-graphics-maintainer@vmware.com \
--cc=drawat@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.