From: Ramalingam C <ramalingam.c@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: igt-dev@lists.freedesktop.org, daniel.vetter@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] kms_content_protection: Disable authentication when failed
Date: Tue, 16 Apr 2019 15:36:06 +0530 [thread overview]
Message-ID: <20190416100605.GB25423@intel.com> (raw)
In-Reply-To: <20190416085443.GF13337@phenom.ffwll.local>
On 2019-04-16 at 10:54:43 +0200, Daniel Vetter wrote:
> On Tue, Apr 16, 2019 at 11:12:30AM +0300, Martin Peres wrote:
> > On 11/04/2019 14:23, Ramalingam C wrote:
> > > When content protection authentication is failed in kernel after all
> > > requried retries, before declaring the test failure, set the content
> > > protection to UNDESIRED state.
> > >
> > > This will avoid the HDCP authentication attempts in subsequent modesets
> > > from other tests.
> > >
> > > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110376
>
> exit handler would be another option, but they're also not without issues.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Martin and Daniel,
Thanks for the review. Change is merged in upstream.
-Ram
>
> > > ---
> > > tests/kms_content_protection.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/tests/kms_content_protection.c b/tests/kms_content_protection.c
> > > index 7fc8542e769a..ae6ab497ea21 100644
> > > --- a/tests/kms_content_protection.c
> > > +++ b/tests/kms_content_protection.c
> > > @@ -212,6 +212,10 @@ static void test_cp_enable_with_retry(igt_output_t *output,
> > > if (!ret && --retry)
> > > igt_debug("Retry (%d/2) ...\n", 3 - retry);
> > > } while (retry && !ret);
> > > +
> > > + if (!ret)
> > > + test_cp_disable(output, s);
> > > +
> > > igt_assert_f(ret, "Content Protection not enabled\n");
> > > }
> > >
> > >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-04-16 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 11:23 [igt-dev] [PATCH i-g-t] kms_content_protection: Disable authentication when failed Ramalingam C
2019-04-11 14:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-11 18:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-16 8:12 ` [igt-dev] [PATCH i-g-t] " Martin Peres
2019-04-16 8:54 ` Daniel Vetter
2019-04-16 10:06 ` Ramalingam C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416100605.GB25423@intel.com \
--to=ramalingam.c@intel.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.