From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jiri Slaby <jslaby@suse.com>, Phil Elwell <phil@raspberrypi.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Stefan Potyra <Stefan.Potyra@elektrobit.com>,
Mao Wenan <maowenan@huawei.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: fix unused label warning
Date: Tue, 16 Apr 2019 15:11:01 +0200 [thread overview]
Message-ID: <20190416131101.GD7406@kroah.com> (raw)
In-Reply-To: <20190416123321.3577638-1-arnd@arndb.de>
On Tue, Apr 16, 2019 at 02:33:14PM +0200, Arnd Bergmann wrote:
> A bugfix introduced a harmless warning:
>
> drivers/tty/serial/sc16is7xx.c:1523:1: error: unused label 'err_spi' [-Werror,-Wunused-label]
>
> Move each label inside the correct #ifdef.
>
> Fixes: ac0cdb3d9901 ("sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/tty/serial/sc16is7xx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Someone sent this same patch a week earlier. I'll merge yours into
it...
thanks,
greg k-h
prev parent reply other threads:[~2019-04-16 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 12:33 [PATCH] serial: sc16is7xx: fix unused label warning Arnd Bergmann
2019-04-16 13:11 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416131101.GD7406@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Stefan.Potyra@elektrobit.com \
--cc=arnd@arndb.de \
--cc=gustavo@embeddedor.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=phil@raspberrypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.