From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4] syscalls/fanotify15: verify fid for dirent events
Date: Tue, 16 Apr 2019 17:00:15 +0200 [thread overview]
Message-ID: <20190416150015.GA22754@rei.lan> (raw)
In-Reply-To: <CAOQ4uxiuLd3C0ctx-+fUkAT8XZyY5SOw61-wB8BTdHh0FVPBXg@mail.gmail.com>
Hi!
> > Can put this code into an header in the fanotify/ directory along with
> > the event_t structure definiton so that we do not carry two copies of
> > nearly identical code.
>
> Correct, but I would rather leave the event_t structure private to the test
> because it may have other fields in future tests of similar pattern...
>
> >
> > If we passed a pointer to the event_t structure instead of the index we
> > can call this function in a loop in the get_object_stats() in
> > fanotify13, right?
> >
>
> ...so I'd prefer to pass a pointer to fsid and file_handle to helper instead,
> something like:
> void fanotify_get_fid(const char *path, __kernel_fsid_t *fsid, and
> struct file_handle *handle)
Sounds good to me as well.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-04-16 15:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 10:01 [LTP] [PATCH 0/4] fanotify: FAN_REPORT_FID and Directory Modification Events Matthew Bobrowski
2019-04-02 10:01 ` [LTP] [PATCH 1/4] syscalls/fanotify01: add FAN_REPORT_FID test cases Amir Goldstein
2019-04-15 15:18 ` Cyril Hrubis
2019-04-02 10:02 ` [LTP] [PATCH 2/4] syscalls/fanotify13: new test to verify FAN_REPORT_FID functionality Matthew Bobrowski
2019-04-16 13:41 ` Cyril Hrubis
2019-04-16 14:23 ` Amir Goldstein
2019-04-19 8:37 ` Matthew Bobrowski
2019-04-19 9:07 ` Amir Goldstein
2019-04-02 10:02 ` [LTP] [PATCH 3/4] syscalls/fanotify14: new test to validate FAN_REPORT_FID interface return values Matthew Bobrowski
2019-04-16 14:04 ` Cyril Hrubis
2019-04-19 8:38 ` Matthew Bobrowski
2019-04-02 10:02 ` [LTP] [PATCH 4/4] syscalls/fanotify15: verify fid for dirent events Matthew Bobrowski
2019-04-16 14:29 ` Cyril Hrubis
2019-04-16 14:59 ` Amir Goldstein
2019-04-16 15:00 ` Cyril Hrubis [this message]
2019-04-18 18:36 ` Amir Goldstein
2019-04-18 18:58 ` Cyril Hrubis
2019-04-18 19:10 ` Amir Goldstein
2019-04-18 19:42 ` Cyril Hrubis
2019-04-19 7:18 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416150015.GA22754@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.