From: Vivek Goyal <vgoyal@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH 3/9] fuse: export fuse_drop_waiting()
Date: Tue, 16 Apr 2019 14:28:49 -0400 [thread overview]
Message-ID: <20190416182849.GD2222@redhat.com> (raw)
In-Reply-To: <20190416180322.65113-4-bo.liu@linux.alibaba.com>
On Wed, Apr 17, 2019 at 02:03:16AM +0800, Liu Bo wrote:
> virtio-fs will need to do ref count against FORGET requests from
> outside fs/fuse/dev.c. Make the symbol visible.
>
Who needs it? virtio-fs does not seem to be calling it?
Vivek
> Reviewed-by: Liu Bo <bo.liu@linux.alibaba.com>
> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> Signed-off-by: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
> ---
> fs/fuse/dev.c | 3 ++-
> fs/fuse/fuse_i.h | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 07ae706..7e6afd0 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -128,7 +128,7 @@ static bool fuse_block_alloc(struct fuse_conn *fc, bool for_background)
> return !fc->initialized || (for_background && fc->blocked);
> }
>
> -static void fuse_drop_waiting(struct fuse_conn *fc)
> +void fuse_drop_waiting(struct fuse_conn *fc)
> {
> if (fc->connected) {
> atomic_dec(&fc->num_waiting);
> @@ -137,6 +137,7 @@ static void fuse_drop_waiting(struct fuse_conn *fc)
> wake_up_all(&fc->blocked_waitq);
> }
> }
> +EXPORT_SYMBOL_GPL(fuse_drop_waiting);
>
> static struct fuse_req *__fuse_get_req(struct fuse_conn *fc, unsigned npages,
> bool for_background)
> diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
> index 2c32846..171aee8 100644
> --- a/fs/fuse/fuse_i.h
> +++ b/fs/fuse/fuse_i.h
> @@ -1199,6 +1199,7 @@ ssize_t fuse_getxattr(struct inode *inode, const char *name, void *value,
> * Get the next unique ID for a request
> */
> u64 fuse_get_unique(struct fuse_iqueue *fiq);
> +void fuse_drop_waiting(struct fuse_conn *fc);
> void fuse_dax_free_mem_worker(struct work_struct *work);
> void fuse_removemapping(struct inode *inode);
>
> --
> 1.8.3.1
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
next prev parent reply other threads:[~2019-04-16 18:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 18:03 [Virtio-fs] [PATCH 0/9] virtio-fs fixes Liu Bo
2019-04-16 18:03 ` [Virtio-fs] [PATCH 1/9] virtio-fs: fix multiple tag support Liu Bo
2019-04-16 18:09 ` Vivek Goyal
2019-04-16 18:03 ` [Virtio-fs] [PATCH 2/9] virtio-fs: clean up dax mapping before aborting connection Liu Bo
2019-04-16 18:18 ` Vivek Goyal
2019-04-16 18:40 ` Liu Bo
2019-04-16 18:03 ` [Virtio-fs] [PATCH 3/9] fuse: export fuse_drop_waiting() Liu Bo
2019-04-16 18:28 ` Vivek Goyal [this message]
2019-04-16 18:43 ` Liu Bo
2019-04-16 18:03 ` [Virtio-fs] [PATCH 4/9] virtio-fs: fix use-after-free against virtio_fs_vq's fuse_dev info Liu Bo
2019-04-23 19:51 ` Vivek Goyal
2019-04-25 0:16 ` Liu Bo
2019-04-16 18:03 ` [Virtio-fs] [PATCH 5/9] fuse: do not write whole page while page straddles i_size Liu Bo
2019-04-16 20:16 ` Vivek Goyal
2019-04-17 0:12 ` Liu Bo
2019-04-16 18:03 ` [Virtio-fs] [PATCH 6/9] virtio-fs: let dax style override directIO style when dax+cache=none Liu Bo
2019-04-16 19:38 ` Vivek Goyal
2019-04-17 8:25 ` Miklos Szeredi
2019-04-17 19:35 ` Liu Bo
2019-04-25 18:35 ` Vivek Goyal
2019-04-17 20:56 ` Vivek Goyal
2019-04-22 18:55 ` Liu Bo
2019-04-22 18:14 ` Vivek Goyal
2019-04-16 18:03 ` [Virtio-fs] [PATCH 7/9] fuse: return early if punch_hole fails Liu Bo
2019-04-16 19:51 ` Vivek Goyal
2019-04-16 18:03 ` [Virtio-fs] [PATCH 8/9] virtio-fs: honor RLIMIT_FSIZE in fuse_file_fallocate Liu Bo
2019-04-16 19:57 ` Vivek Goyal
2019-04-16 18:03 ` [Virtio-fs] [PATCH 9/9] fuse: fix deadlock in __fuse_file_fallocate() Liu Bo
2019-04-16 18:07 ` Vivek Goyal
2019-05-02 22:10 ` Liu Bo
2019-05-03 15:22 ` Vivek Goyal
2019-04-24 18:41 ` [Virtio-fs] [PATCH 0/9] virtio-fs fixes Vivek Goyal
2019-04-24 23:12 ` Liu Bo
2019-04-25 14:59 ` Vivek Goyal
2019-04-25 18:10 ` Liu Bo
2019-04-27 0:58 ` Liu Bo
2019-04-29 13:18 ` Vivek Goyal
2019-04-30 1:38 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416182849.GD2222@redhat.com \
--to=vgoyal@redhat.com \
--cc=bo.liu@linux.alibaba.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.