From: Borislav Petkov <bp@alien8.de>
To: Xiaochen Shen <xiaochen.shen@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
tony.luck@intel.com, fenghua.yu@intel.com,
reinette.chatre@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org, pei.p.jia@intel.com
Subject: Re: [PATCH 2/2] x86/resctrl: Initialize new resource group with default MBA values
Date: Tue, 16 Apr 2019 22:59:26 +0200 [thread overview]
Message-ID: <20190416205926.GO31772@zn.tnic> (raw)
In-Reply-To: <9e99ed5f-d60a-717c-9322-c6f0b8090d6b@intel.com>
On Wed, Apr 17, 2019 at 04:51:18AM +0800, Xiaochen Shen wrote:
> In this patch we initialize MBA resource and cache resources in separate
> functions rdtgroup_init_cat() and rdtgroup_init_mba(). If
> __init_one_rdt_domain() is only called by rdtgroup_init_cat(), how about
> using function name "__init_one_rdt_domain_cat()"?
I guess but be conservative when adding too many words to a function's
name - that might get heavy when reading the code later.
For example, there's an argument to not suffix it with "_cat": it is
only called by rdtgroup_init_cat() - rdtgroup_init_mba() will not call
it - so the path will remain unique anyway...
Anyway, something to think about - I personally don't have a strong
preference here.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-16 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1554839728-5544-1-git-send-email-xiaochen.shen@intel.com>
2019-04-15 11:34 ` [PATCH 2/2] x86/resctrl: Initialize new resource group with default MBA values Borislav Petkov
2019-04-16 20:51 ` Xiaochen Shen
2019-04-16 20:59 ` Borislav Petkov [this message]
2019-04-16 21:11 ` Xiaochen Shen
2019-04-10 8:24 Xiaochen Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416205926.GO31772@zn.tnic \
--to=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pei.p.jia@intel.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.