From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hGVRF-0001LB-Uz for mharc-qemu-trivial@gnu.org; Tue, 16 Apr 2019 17:16:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGVRD-0001Hy-NY for qemu-trivial@nongnu.org; Tue, 16 Apr 2019 17:16:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGVRC-0007w2-TU for qemu-trivial@nongnu.org; Tue, 16 Apr 2019 17:16:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39240) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGVRA-0007qg-Jp; Tue, 16 Apr 2019 17:16:16 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2A2B308795E; Tue, 16 Apr 2019 21:16:08 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 051835C1B5; Tue, 16 Apr 2019 21:16:07 +0000 (UTC) Date: Tue, 16 Apr 2019 18:16:06 -0300 From: Eduardo Habkost To: Like Xu Cc: qemu-trivial@nongnu.org, Peter Maydell , Thomas Huth , like.xu@intel.com, qemu-devel@nongnu.org, Markus Armbruster , Igor Mammedov Message-ID: <20190416211606.GA2272@habkost.net> References: <1555315185-16414-1-git-send-email-like.xu@linux.intel.com> <1555315185-16414-2-git-send-email-like.xu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1555315185-16414-2-git-send-email-like.xu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 16 Apr 2019 21:16:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 21:16:20 -0000 On Mon, Apr 15, 2019 at 03:59:44PM +0800, Like Xu wrote: > This patch makes the remaining dozen or so uses of the global > current_machine outside vl.c use qdev_get_machine() instead, > and then make current_machine local to vl.c instead of global. > > Suggested-by: Peter Maydell > Signed-off-by: Like Xu Reviewed-by: Eduardo Habkost -- Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:60161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGVRB-0001Hg-SC for qemu-devel@nongnu.org; Tue, 16 Apr 2019 17:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGVRA-0007uw-Sy for qemu-devel@nongnu.org; Tue, 16 Apr 2019 17:16:17 -0400 Date: Tue, 16 Apr 2019 18:16:06 -0300 From: Eduardo Habkost Message-ID: <20190416211606.GA2272@habkost.net> References: <1555315185-16414-1-git-send-email-like.xu@linux.intel.com> <1555315185-16414-2-git-send-email-like.xu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1555315185-16414-2-git-send-email-like.xu@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Like Xu Cc: qemu-trivial@nongnu.org, Peter Maydell , Thomas Huth , like.xu@intel.com, qemu-devel@nongnu.org, Markus Armbruster , Igor Mammedov On Mon, Apr 15, 2019 at 03:59:44PM +0800, Like Xu wrote: > This patch makes the remaining dozen or so uses of the global > current_machine outside vl.c use qdev_get_machine() instead, > and then make current_machine local to vl.c instead of global. > > Suggested-by: Peter Maydell > Signed-off-by: Like Xu Reviewed-by: Eduardo Habkost -- Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9330EC10F13 for ; Tue, 16 Apr 2019 21:17:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67E4220821 for ; Tue, 16 Apr 2019 21:17:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67E4220821 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:42958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGVS4-0001hc-DZ for qemu-devel@archiver.kernel.org; Tue, 16 Apr 2019 17:17:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGVRB-0001Hg-SC for qemu-devel@nongnu.org; Tue, 16 Apr 2019 17:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGVRA-0007uw-Sy for qemu-devel@nongnu.org; Tue, 16 Apr 2019 17:16:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39240) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGVRA-0007qg-Jp; Tue, 16 Apr 2019 17:16:16 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2A2B308795E; Tue, 16 Apr 2019 21:16:08 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 051835C1B5; Tue, 16 Apr 2019 21:16:07 +0000 (UTC) Date: Tue, 16 Apr 2019 18:16:06 -0300 From: Eduardo Habkost To: Like Xu Message-ID: <20190416211606.GA2272@habkost.net> References: <1555315185-16414-1-git-send-email-like.xu@linux.intel.com> <1555315185-16414-2-git-send-email-like.xu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1555315185-16414-2-git-send-email-like.xu@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 16 Apr 2019 21:16:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , qemu-trivial@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, like.xu@intel.com, Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190416211606.G2Z7XfAzQl7sStmVVLneOVpdbFt65P2owpnWw-Q_Yms@z> On Mon, Apr 15, 2019 at 03:59:44PM +0800, Like Xu wrote: > This patch makes the remaining dozen or so uses of the global > current_machine outside vl.c use qdev_get_machine() instead, > and then make current_machine local to vl.c instead of global. > > Suggested-by: Peter Maydell > Signed-off-by: Like Xu Reviewed-by: Eduardo Habkost -- Eduardo