All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	jdelvare@suse.com, andrew@aj.id.au, mine260309@gmail.com,
	Eddie James <eajames@us.ibm.com>
Subject: Re: [PATCH 3/3] hwmon (occ): Add more details to Kconfig help text
Date: Tue, 16 Apr 2019 15:15:11 -0700	[thread overview]
Message-ID: <20190416221511.GA32220@roeck-us.net> (raw)
In-Reply-To: <1555429430-23118-3-git-send-email-eajames@linux.ibm.com>

On Tue, Apr 16, 2019 at 03:43:50PM +0000, Eddie James wrote:
> From: Eddie James <eajames@us.ibm.com>
> 
> The help text needs to spell out how the driver runs on a BMC, as it
> previously seemed to indicate it ran on a POWER processor.
> 
> Signed-off-by: Eddie James <eajames@us.ibm.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/occ/Kconfig | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hwmon/occ/Kconfig b/drivers/hwmon/occ/Kconfig
> index 2a3869f..1658634 100644
> --- a/drivers/hwmon/occ/Kconfig
> +++ b/drivers/hwmon/occ/Kconfig
> @@ -9,8 +9,10 @@ config SENSORS_OCC_P8_I2C
>  	select SENSORS_OCC
>  	help
>  	 This option enables support for monitoring sensors provided by the
> -	 On-Chip Controller (OCC) on a POWER8 processor. Communications with
> -	 the OCC are established through I2C bus.
> +	 On-Chip Controller (OCC) on a POWER8 processor. However, this driver
> +	 can only run on a baseboard management controller (BMC) connected to
> +	 the P8, not the POWER processor itself. Communications with the OCC are
> +	 established through I2C bus.
>  
>  	 This driver can also be built as a module. If so, the module will be
>  	 called occ-p8-hwmon.
> @@ -22,8 +24,10 @@ config SENSORS_OCC_P9_SBE
>  	select SENSORS_OCC
>  	help
>  	 This option enables support for monitoring sensors provided by the
> -	 On-Chip Controller (OCC) on a POWER9 processor. Communications with
> -	 the OCC are established through SBE fifo on an FSI bus.
> +	 On-Chip Controller (OCC) on a POWER9 processor. However, this driver
> +	 can only run on a baseboard management controller (BMC) connected to
> +	 the P9, not the POWER processor itself. Communications with the OCC are
> +	 established through SBE fifo on an FSI bus.
>  
>  	 This driver can also be built as a module. If so, the module will be
>  	 called occ-p9-hwmon.

  reply	other threads:[~2019-04-16 22:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 15:43 [PATCH 1/3] hwmon (occ): Store error condition for rate-limited polls Eddie James
2019-04-16 15:43 ` [PATCH 2/3] hwmon (occ): Prevent sysfs error attribute from returning error Eddie James
2019-04-16 22:14   ` Guenter Roeck
2019-04-16 15:43 ` [PATCH 3/3] hwmon (occ): Add more details to Kconfig help text Eddie James
2019-04-16 22:15   ` Guenter Roeck [this message]
2019-04-16 22:12 ` [PATCH 1/3] hwmon (occ): Store error condition for rate-limited polls Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416221511.GA32220@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=andrew@aj.id.au \
    --cc=eajames@linux.ibm.com \
    --cc=eajames@us.ibm.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mine260309@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.