From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH] fscrypt: remove WARN_ON_ONCE() when decryption fails
Date: Tue, 16 Apr 2019 18:45:24 -0400 [thread overview]
Message-ID: <20190416224524.GA13432@mit.edu> (raw)
In-Reply-To: <20190315211632.231638-1-ebiggers@kernel.org>
On Fri, Mar 15, 2019 at 02:16:32PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> If decrypting a block fails, fscrypt did a WARN_ON_ONCE(). But WARN is
> meant for kernel bugs, which this isn't; this could be hit by fuzzers
> using fault injection, for example. Also, there is already a proper
> warning message logged in fscrypt_do_page_crypto(), so the WARN doesn't
> add much.
>
> Just remove the unnessary WARN.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Looks good, applied.
- Ted
prev parent reply other threads:[~2019-04-16 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 21:16 [PATCH] fscrypt: remove WARN_ON_ONCE() when decryption fails Eric Biggers
2019-04-16 22:45 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416224524.GA13432@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.