From: Adrian Bunk <bunk@stusta.de>
To: richard.purdie@linuxfoundation.org
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] bitbake.conf: add git-lfs to HOSTTOOLS_NONFATAL
Date: Wed, 17 Apr 2019 12:35:20 +0300 [thread overview]
Message-ID: <20190417093520.GA895@localhost> (raw)
In-Reply-To: <eac500ca51a96c769ab3080bcd78dd93316bea9f.camel@linuxfoundation.org>
On Wed, Apr 17, 2019 at 09:46:25AM +0100, richard.purdie@linuxfoundation.org wrote:
> On Wed, 2019-04-17 at 10:20 +0800, Saini, Naveen Kumar wrote:
>...
> > Should this be added to HOSTTOOLS instead so lfs files are always
> > fetched for packages that use it?
>
> No, that would mean everyone has to install it.
>
> I'm ok with adding it to HOSTTOOLS_NONFATAL as soon as we have some
> mechanism in the fetcher or in recipes which detects lfs usage and hard
> errors if its present but git-lfs is not installed.
>
> That way its deterministic - it builds with git-lfs installed and
> errors if it is not.
Is it OK that some packages are not buildable at all on supported
distributions?
Your "everyone has to install it" worry misses the much bigger problem
that git-lfs is a relatively new tool and not available in distributions
like Debian 9 or Ubuntu 16.04.
> Cheers,
>
> Richard
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2019-04-17 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 5:59 [PATCH] bitbake.conf: add git-lfs to HOSTTOOLS_NONFATAL Naveen Saini
2019-04-16 10:23 ` Richard Purdie
2019-04-17 2:20 ` Saini, Naveen Kumar
2019-04-17 8:46 ` richard.purdie
2019-04-17 9:35 ` Adrian Bunk [this message]
2019-04-17 9:37 ` richard.purdie
2019-04-17 9:50 ` Adrian Bunk
2019-04-17 9:57 ` Bach, Pascal
2019-04-17 10:25 ` Adrian Bunk
2019-04-17 10:56 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417093520.GA895@localhost \
--to=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.