From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CAD0C282DA for ; Wed, 17 Apr 2019 11:43:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4759D20821 for ; Wed, 17 Apr 2019 11:43:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rCgqpCEX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4759D20821 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hofr.at Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tt1gKAttZtoFrzYpFyKmLtoFbzbmgyBcf/SI4A48L8k=; b=rCgqpCEXgv+dJS JtWpYsLMNqH1ccf8izpb0MHuQkqdnJ8WjSM1g4jl0Hukp5771Tl8l+aaQG75N2bRQ+9Ov5q9tdH4A J/ojroa08jZaD7qdRjRitU9ARGbp31JtrTRKWyaAT+ZMTvzvQWa4uvjfk+lLjHYM4kcbbxV3loJqB L7BrSkG2YgN+42Oi2PAnRBPs82gvCXMd8jdf6Awd1i9MBzEro1LJjxcJcFrLiCt9kTpyExBhcSKaP kf8l+WYa4gorvEH64mqvnvLuJ6uyM3zp3eky08r0cSZ7kHerkULVbK3TZWpkZO6oe+Egvqi7n+3zp HdUrWKgKUvimCjainTMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGiyZ-0007OY-Bb; Wed, 17 Apr 2019 11:43:39 +0000 Received: from 178.115.242.59.static.drei.at ([178.115.242.59] helo=mail.osadl.at) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGiyV-0007Ni-4L for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2019 11:43:37 +0000 Received: by mail.osadl.at (Postfix, from userid 1001) id E221B5C2F68; Wed, 17 Apr 2019 13:42:28 +0200 (CEST) Date: Wed, 17 Apr 2019 13:42:28 +0200 From: Nicholas Mc Guire To: Andrew Lunn Subject: Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure Message-ID: <20190417114228.GA20280@osadl.at> References: <1555386991-8855-1-git-send-email-hofrat@osadl.org> <20190416133957.GB29190@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190416133957.GB29190@lunn.ch> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190417_044335_421116_B7843853 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , Gregory Clement , Russell King , linux-kernel@vger.kernel.org, Nicholas Mc Guire , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: > On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: > > > Note that this will trigger a checkpatch WARNING > > "WARNING: Possible unnecessary 'out of memory' message" > > but comparing the oops with an without the one-line pr_err I would > > argue that it makes sense to include it: > > Hi Nicholas > > It might be worth adding this as a comment, so that newbies don't > submit patches removing the pr_err() because of the checkpatch > warning. > hmm... I think if we start doing that we would make quite a mess of documentation in the kernel. Also note its a warning stating "possible unneceessary" - so I would not see the necessity. At most I would include a note on this in the commit message so that anyone checking the origin would see that this is intenttional - assuming that people modifying code would be using git blame to locate the origin of any code... thx! hofrat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8913BC282DA for ; Wed, 17 Apr 2019 11:43:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 600F320821 for ; Wed, 17 Apr 2019 11:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731974AbfDQLnT (ORCPT ); Wed, 17 Apr 2019 07:43:19 -0400 Received: from 178.115.242.59.static.drei.at ([178.115.242.59]:45609 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729578AbfDQLnS (ORCPT ); Wed, 17 Apr 2019 07:43:18 -0400 Received: by mail.osadl.at (Postfix, from userid 1001) id E221B5C2F68; Wed, 17 Apr 2019 13:42:28 +0200 (CEST) Date: Wed, 17 Apr 2019 13:42:28 +0200 From: Nicholas Mc Guire To: Andrew Lunn Cc: Nicholas Mc Guire , Jason Cooper , Gregory Clement , Sebastian Hesselbarth , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] ARM: mvebu: at least report the kzalloc failure Message-ID: <20190417114228.GA20280@osadl.at> References: <1555386991-8855-1-git-send-email-hofrat@osadl.org> <20190416133957.GB29190@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416133957.GB29190@lunn.ch> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 16, 2019 at 03:39:57PM +0200, Andrew Lunn wrote: > On Tue, Apr 16, 2019 at 05:56:31AM +0200, Nicholas Mc Guire wrote: > > > Note that this will trigger a checkpatch WARNING > > "WARNING: Possible unnecessary 'out of memory' message" > > but comparing the oops with an without the one-line pr_err I would > > argue that it makes sense to include it: > > Hi Nicholas > > It might be worth adding this as a comment, so that newbies don't > submit patches removing the pr_err() because of the checkpatch > warning. > hmm... I think if we start doing that we would make quite a mess of documentation in the kernel. Also note its a warning stating "possible unneceessary" - so I would not see the necessity. At most I would include a note on this in the commit message so that anyone checking the origin would see that this is intenttional - assuming that people modifying code would be using git blame to locate the origin of any code... thx! hofrat